Merge pull request #53 from kfswain/cleanup

Fixing hermetic_test, small formatting changes

Author: k8s-ci-robot

pkg/ext-proc/backend/provider_test.go

@@ -82,7 +82,8 @@ func TestProvider(t *testing.T) {
 						MaxActiveModels:     0,
 						ActiveModels:        map[string]int{},
 					},
-				}},
+				},
+			},
 		},
 	}
 

pkg/ext-proc/test/hermetic_test.go

@@ -78,7 +78,14 @@ func TestHandleRequestBody(t *testing.T) {
 						RawValue: []byte("address-1"),
 					},
 				},
+				{
+					Header: &configPb.HeaderValue{
+						Key:      "Content-Length",
+						RawValue: []byte("70"),
+					},
+				},
 			},
+			wantBody: []byte("{\"max_tokens\":100,\"model\":\"my-model\",\"prompt\":\"hello\",\"temperature\":0}"),
 		},
 	}
 
@@ -93,12 +100,11 @@ func TestHandleRequestBody(t *testing.T) {
 							HeaderMutation: &extProcPb.HeaderMutation{
 								SetHeaders: test.wantHeaders,
 							},
-							// TODO: Also check body once it's added.
-							// BodyMutation: &extProcPb.BodyMutation{
-							// 	Mutation: &extProcPb.BodyMutation_Body{
-							// 		Body: test.wantBody,
-							// 	},
-							// },
+							BodyMutation: &extProcPb.BodyMutation{
+								Mutation: &extProcPb.BodyMutation_Body{
+									Body: test.wantBody,
+								},
+							},
 						},
 					},
 				},

pkg/ext-proc/test/utils.go

@@ -26,7 +26,7 @@ func StartExtProc(port int, refreshPodsInterval, refreshMetricsInterval time.Dur
 		pms[pod.Pod] = pod
 	}
 	pmc := &backend.FakePodMetricsClient{Res: pms}
-	pp := backend.NewProvider(pmc, &backend.K8sDatastore{Pods: &sync.Map{}})
+	pp := backend.NewProvider(pmc, &backend.K8sDatastore{Pods: populatePodDatastore(pods)})
 	if err := pp.Init(refreshPodsInterval, refreshMetricsInterval); err != nil {
 		klog.Fatalf("failed to initialize: %v", err)
 	}
@@ -78,3 +78,12 @@ func FakePod(index int) backend.Pod {
 	}
 	return pod
 }
+
+func populatePodDatastore(pods []*backend.PodMetrics) *sync.Map {
+	returnVal := &sync.Map{}
+
+	for _, pod := range pods {
+		returnVal.Store(pod.Pod, true)
+	}
+	return returnVal
+}