Skip to content

Commit d5ec68a

Browse files
authored
rename of experimental http route creation section in helm (#2123)
Signed-off-by: Nir Rozenbaum <[email protected]>
1 parent 2c2ea1c commit d5ec68a

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

config/charts/inferencepool/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -249,9 +249,9 @@ The following table list the configurable parameters of the chart.
249249
| `inferenceExtension.tracing.sampling.samplerArg` | Sampler-specific argument. For `parentbased_traceidratio`, this defines the base sampling rate for new traces (root spans), as a float string in the range [0.0, 1.0]. For example, "0.1" enables 10% sampling. |
250250
| `inferenceExtension.volumes` | List of volumes to mount in the EPP deployment as free-form YAML. Optional. |
251251
| `inferenceExtension.volumeMounts` | List of volume mounts for the EPP container as free-form YAML. Optional. |
252-
| `experimentalGateway.enabled` | Boolean flag to indicate whether the helm chart should create HttpRoute. Defaults to `False`. Optional. |
253-
| `experimentalGateway.name` | Name of the inference-gateway to be used when creating the HttpRoute. Used only if `experimentalGateway` is enabled. Optional. |
254-
| `experimentalGateway.baseModel` | Base model used in the current instance of the epp. When this value is set the HttpRoute will be set to match the pool based on `X-Gateway-Base-Model-Name` header. Optional. |
252+
| `experimentalHttpRoute.enabled` | Boolean flag to indicate whether the helm chart should create HttpRoute. Defaults to `False`. Optional. |
253+
| `experimentalHttpRoute.inferenceGatewayName` | Name of the inference-gateway to be used when creating the HttpRoute. Used only if `experimentalHttpRoute` is enabled. Optional. |
254+
| `experimentalHttpRoute.baseModel` | Base model used in the current instance of the epp. When this value is set the HttpRoute will be set to match the pool based on `X-Gateway-Base-Model-Name` header. Optional. |
255255
| `inferenceExtension.sidecar.enabled` | Enables or disables the sidecar container in the EPP deployment. Defaults to `false`. |
256256
| `inferenceExtension.sidecar.name` | Name of the sidecar container. Required when the sidecar is enabled. |
257257
| `inferenceExtension.sidecar.image` | Image for the sidecar container. Required when the sidecar is enabled. |

config/charts/inferencepool/templates/httproute.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{{- if .Values.experimentalGateway.enabled }}
1+
{{- if .Values.experimentalHttpRoute.enabled }}
22
apiVersion: gateway.networking.k8s.io/v1
33
kind: HTTPRoute
44
metadata:
@@ -8,7 +8,7 @@ spec:
88
parentRefs:
99
- group: gateway.networking.k8s.io
1010
kind: Gateway
11-
name: {{ .Values.experimentalGateway.name }}
11+
name: {{ .Values.experimentalHttpRoute.inferenceGatewayName }}
1212
rules:
1313
- backendRefs:
1414
- group: inference.networking.k8s.io
@@ -18,11 +18,11 @@ spec:
1818
- path:
1919
type: PathPrefix
2020
value: /
21-
{{- if .Values.experimentalGateway.baseModel }}
21+
{{- if .Values.experimentalHttpRoute.baseModel }}
2222
headers:
2323
- type: Exact
2424
name: X-Gateway-Base-Model-Name
25-
value: {{ .Values.experimentalGateway.baseModel }}
25+
value: {{ .Values.experimentalHttpRoute.baseModel }}
2626
{{- end }}
2727
timeouts:
2828
request: 300s

config/charts/inferencepool/values.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -185,11 +185,11 @@ provider:
185185
# http:
186186
# maxRequestsPerConnection: 256000
187187

188-
# experimentalGateway section is used to deploy httproute as part of the epp helm chart.
189-
# this section should be extracted to a separate chart.
190-
experimentalGateway:
188+
# experimentalHttpRoute section is used to deploy httproute as part of the epp helm chart.
189+
# this section is temporary and should be extracted to a separate chart.
190+
experimentalHttpRoute:
191191
enabled: false # a flag to indicate whether to create the httproute as part of the chart or not.
192-
name: inference-gateway
192+
inferenceGatewayName: inference-gateway
193193

194194
# DEPRECATED and will be removed in v1.3. Instead, use `provider.istio.*`.
195195
istio:

site-src/_includes/epp.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
helm install vllm-llama3-8b-instruct \
66
--set inferencePool.modelServers.matchLabels.app=vllm-llama3-8b-instruct \
77
--set provider.name=$GATEWAY_PROVIDER \
8-
--set experimentalGateway.enabled=true \
8+
--set experimentalHttpRoute.enabled=true \
99
--version $IGW_CHART_VERSION \
1010
oci://registry.k8s.io/gateway-api-inference-extension/charts/inferencepool
1111
```
@@ -17,7 +17,7 @@
1717
helm install vllm-llama3-8b-instruct \
1818
--set inferencePool.modelServers.matchLabels.app=vllm-llama3-8b-instruct \
1919
--set provider.name=$GATEWAY_PROVIDER \
20-
--set experimentalGateway.enabled=true \
20+
--set experimentalHttpRoute.enabled=true \
2121
--version $IGW_CHART_VERSION \
2222
oci://registry.k8s.io/gateway-api-inference-extension/charts/inferencepool
2323
```
@@ -29,7 +29,7 @@
2929
helm install vllm-llama3-8b-instruct \
3030
--set inferencePool.modelServers.matchLabels.app=vllm-llama3-8b-instruct \
3131
--set provider.name=$GATEWAY_PROVIDER \
32-
--set experimentalGateway.enabled=true \
32+
--set experimentalHttpRoute.enabled=true \
3333
--version $IGW_CHART_VERSION \
3434
oci://registry.k8s.io/gateway-api-inference-extension/charts/inferencepool
3535
```
@@ -41,7 +41,7 @@
4141
helm install vllm-llama3-8b-instruct \
4242
--set inferencePool.modelServers.matchLabels.app=vllm-llama3-8b-instruct \
4343
--set provider.name=$GATEWAY_PROVIDER \
44-
--set experimentalGateway.enabled=true \
44+
--set experimentalHttpRoute.enabled=true \
4545
--version $IGW_CHART_VERSION \
4646
oci://registry.k8s.io/gateway-api-inference-extension/charts/inferencepool
4747
```

0 commit comments

Comments
 (0)