Skip to content

Commit dd6834a

Browse files
authored
fix: make port number become pointer (#1400)
* make port number become pointer * fixed ut * updated crd * change to use pointer * changed comment
1 parent 5b4fbb9 commit dd6834a

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

api/v1/inferencepool_types.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,8 @@ type Extension struct {
123123
// Service.
124124
//
125125
// +optional
126-
PortNumber PortNumber `json:"portNumber,omitempty"`
126+
//nolint:kubeapilinter // ignore kubeapilinter here as we want to use pointer here as 0 usually means all ports.
127+
PortNumber *PortNumber `json:"portNumber,omitempty"`
127128

128129
// Configures how the gateway handles the case when the extension is not responsive.
129130
// Defaults to failClose.

api/v1/zz_generated.deepcopy.go

Lines changed: 5 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apix/v1alpha2/inferencepool_conversion_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ func TestInferencePoolConvertTo(t *testing.T) {
104104
Group: &v1Group,
105105
Kind: v1Kind,
106106
Name: "my-epp-service",
107-
PortNumber: v1PortNumber,
107+
PortNumber: &v1PortNumber,
108108
FailureMode: v1FailureMode,
109109
},
110110
},
@@ -239,7 +239,7 @@ func TestInferencePoolConvertFrom(t *testing.T) {
239239
Group: &v1Group,
240240
Kind: v1Kind,
241241
Name: "my-epp-service",
242-
PortNumber: v1PortNumber,
242+
PortNumber: &v1PortNumber,
243243
FailureMode: v1FailureMode,
244244
},
245245
},

0 commit comments

Comments
 (0)