Adding Accepted and ResolvedRefs conditions to InferencePool (#446)

Author: robscott

api/v1alpha2/inferencepool_types.go

@@ -159,10 +159,11 @@ type InferencePoolStatus struct {
 	Parents []PoolStatus `json:"parent,omitempty"`
 }
 
-// PoolStatus defines the observed state of InferencePool from a gateway.
+// PoolStatus defines the observed state of InferencePool from a Gateway.
 type PoolStatus struct {
 	// GatewayRef indicates the gateway that observed state of InferencePool.
 	GatewayRef corev1.ObjectReference `json:"parentRef"`
+
 	// Conditions track the state of the InferencePool.
 	//
 	// Known condition types are:
@@ -180,27 +181,67 @@ type PoolStatus struct {
 // InferencePoolConditionType is a type of condition for the InferencePool
 type InferencePoolConditionType string
 
-// InferencePoolConditionReason is the reason for a given InferencePoolConditionType
-type InferencePoolConditionReason string
+// InferencePoolReason is the reason for a given InferencePoolConditionType
+type InferencePoolReason string
 
 const (
-	// PoolConditionReady indicates if the pool is ready to accept traffic, and if not, why.
+	// This condition indicates whether the route has been accepted or rejected
+	// by a Gateway, and why.
 	//
 	// Possible reasons for this condition to be True are:
 	//
-	// * "Ready"
+	// * "Accepted"
+	//
+	// Possible reasons for this condition to be False are:
+	//
+	// * "NotSupportedByGateway"
 	//
 	// Possible reasons for this condition to be Unknown are:
 	//
 	// * "Pending"
 	//
-	PoolConditionReady InferencePoolConditionType = "Ready"
+	// Controllers MAY raise this condition with other reasons, but should
+	// prefer to use the reasons listed above to improve interoperability.
+	InferencePoolConditionAccepted InferencePoolConditionType = "Accepted"
+
+	// This reason is used with the "Accepted" condition when the Route has been
+	// accepted by the Gateway.
+	InferencePoolReasonAccepted InferencePoolReason = "Accepted"
+
+	// This reason is used with the "Accepted" condition when the InferencePool
+	// has not been accepted by a Gateway because the Gateway does not support
+	// InferencePool as a backend.
+	InferencePoolReasonNotSupportedByGateway InferencePoolReason = "NotSupportedByGateway"
+
+	// This reason is used with the "Accepted" when a controller has not yet
+	// reconciled the route.
+	InferencePoolReasonPending InferencePoolReason = "Pending"
+)
+
+const (
+	// This condition indicates whether the controller was able to resolve all
+	// the object references for the InferencePool.
+	//
+	// Possible reasons for this condition to be true are:
+	//
+	// * "ResolvedRefs"
+	//
+	// Possible reasons for this condition to be False are:
+	//
+	// * "InvalidExtnesionRef"
+	//
+	// Controllers MAY raise this condition with other reasons, but should
+	// prefer to use the reasons listed above to improve interoperability.
+	ModelConditionResolvedRefs InferencePoolConditionType = "ResolvedRefs"
 
-	// PoolReasonReady is the desired state. The pool and its components are initialized and ready for traffic.
-	PoolReasonReady InferencePoolConditionReason = "Ready"
+	// This reason is used with the "ResolvedRefs" condition when the condition
+	// is true.
+	ModelReasonResolvedRefs InferencePoolReason = "ResolvedRefs"
 
-	// PoolReasonPending is the initial state, and indicates that the controller has not yet reconciled this pool.
-	PoolReasonPending InferencePoolConditionReason = "Pending"
+	// This reason is used with the "ResolvedRefs" condition when the
+	// ExtensionRef is invalid in some way. This can include an unsupported kind
+	// or API group, or a reference to a resource that can not be found.
+	ModelReasonInvalidExtensionRef InferencePoolReason = "InvalidExtensionRef"
 )
 
 func init() {

config/crd/bases/inference.networking.x-k8s.io_inferencepools.yaml

@@ -146,7 +146,7 @@ spec:
                   means the route has not been attached to any Gateway.
                 items:
                   description: PoolStatus defines the observed state of InferencePool
-                    from a gateway.
+                    from a Gateway.
                   properties:
                     conditions:
                       default: