Resolves initial review comments

Signed-off-by: Daneyon Hansen <[email protected]>

Author: danehans

api/v1/inferencepool_types.go

@@ -218,10 +218,11 @@ type ParentStatus struct {
 	// longer necessary.
 	//
 	// +required
-	ControllerName ParentController `json:"controllerName"`
+	//nolint:kubeapilinter // should not have omitempty since the field is required
+	ControllerName ControllerName `json:"controllerName"`
 }
 
-// ParentController is the name of a controller that manages ParentStatus. It must be a domain prefixed
+// ControllerName is the name of a controller that manages ParentStatus. It must be a domain prefixed
 // path.
 //
 // Valid values include:
@@ -236,7 +237,7 @@ type ParentStatus struct {
 // +kubebuilder:validation:MinLength=1
 // +kubebuilder:validation:MaxLength=253
 // +kubebuilder:validation:Pattern=`^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*\/[A-Za-z0-9\/\-._~%!$&'()*+,;=:]+$`
-type ParentController string
+type ControllerName string
 
 // InferencePoolConditionType is a type of status condition for the InferencePool.
 type InferencePoolConditionType string
@@ -318,7 +319,8 @@ const (
 	//
 	// Possible reasons for this condition to be False are:
 	//
-	// * "Invalid"
+	// * "NotRequested"
+	// * "NotSupported"
 	//
 	// Controllers MAY raise this condition with other reasons, but should
 	// prefer to use the reasons listed above to improve interoperability.
@@ -328,10 +330,15 @@ const (
 	// condition is true.
 	InferencePoolReasonExported InferencePoolReason = "Exported"
 
-	// InferencePoolReasonInvalid is a reason used with the "Exported" condition when the
-	// InferencePool cannot be exported for some reason. A controller should provide
-	// additional information in the condition message.
-	InferencePoolReasonInvalid InferencePoolReason = "Invalid"
+	// InferencePoolReasonNotRequested is a reason used with the "Exported" condition when the
+	// the "Exported" condition is false and no export was requested by the InferencePool. This
+	// indicates a deliberate non-action rather than an error.
+	InferencePoolReasonNotRequested InferencePoolReason = "NotRequested"
+
+	// InferencePoolReasonNotSupported is a reason used with the "Exported" condition when the
+	// InferencePool condition is false and the export was requested but is not supported by the
+	// implementation. Controllers should include details in the condition message.
+	InferencePoolReasonNotSupported InferencePoolReason = "NotSupported"
 )
 
 // ParentReference identifies an API object. It is used to associate the InferencePool with a

apix/v1alpha1/inferencepoolimport_types.go

@@ -35,11 +35,6 @@ type InferencePoolImport struct {
 	// +optional
 	metav1.ObjectMeta `json:"metadata,omitempty"`
 
-	// Spec defines the desired state of the InferencePoolImport.
-	//
-	// +required
-	Spec InferencePoolImportSpec `json:"spec,omitzero"`
-
 	// Status defines the observed state of the InferencePoolImport.
 	//
 	// +optional
@@ -56,9 +51,6 @@ type InferencePoolImportList struct {
 	Items           []InferencePoolImport `json:"items"`
 }
 
-// InferencePoolImportSpec defines the desired state of the InferencePoolImport.
-type InferencePoolImportSpec struct {}
-
 // InferencePoolImportStatus defines the observed state of the InferencePoolImport.
 type InferencePoolImportStatus struct {
     // Controllers is a list of controllers that are responsible for managing the InferencePoolImport.
@@ -136,10 +128,16 @@ type ImportController struct {
 // +kubebuilder:validation:Pattern=`^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*\/[A-Za-z0-9\/\-._~%!$&'()*+,;=:]+$`
 type ControllerName string
 
-// ExportingCluster defines a cluster that exported the InferencePool associated to this InferencePoolImport.
+// ClusterName is the name of a cluster that exported the InferencePool.
+//
+// +kubebuilder:validation:MinLength=1
+// +kubebuilder:validation:MaxLength=253
+type ClusterName string
+
+// ExportingCluster defines a cluster that exported the InferencePool that backs this InferencePoolImport.
 type ExportingCluster struct {
     // Name of the exporting cluster (must be unique within the list). 
     //
     // +kubebuilder:validation:Required
-    Name string `json:"name"`
+    Name ClusterName `json:"name"`
 }

apix/v1alpha1/zz_generated.deepcopy.go

@@ -38,9 +38,6 @@ spec:
             type: string
           metadata:
             type: object
-          spec:
-            description: Spec defines the desired state of the InferencePoolImport.
-            type: object
           status:
             description: Status defines the observed state of the InferencePoolImport.
             properties:
@@ -125,11 +122,13 @@ spec:
                         from the exported InferencePool(s).
                       items:
                         description: ExportingCluster defines a cluster that exported
-                          the InferencePool associated to this InferencePoolImport.
+                          the InferencePool that backs this InferencePoolImport.
                         properties:
                           name:
                             description: Name of the exporting cluster (must be unique
                               within the list).
+                            maxLength: 253
+                            minLength: 1
                             type: string
                         required:
                         - name
@@ -319,8 +318,6 @@ spec:
             required:
             - controllers
             type: object
-        required:
-        - spec
         type: object
     served: true
     storage: true

client-go/applyconfiguration/api/v1/parentstatus.go

@@ -15,6 +15,32 @@ inference.networking.k8s.io API group.
 
 
 
+#### ControllerName
+
+_Underlying type:_ _string_
+
+ControllerName is the name of a controller that manages ParentStatus. It must be a domain prefixed
+path.
+
+Valid values include:
+
+* "example.com/bar"
+
+Invalid values include:
+
+* "example.com" - must include path
+* "foo.example.com" - must include path
+
+_Validation:_
+- MaxLength: 253
+- MinLength: 1
+- Pattern: `^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*\/[A-Za-z0-9\/\-._~%!$&'()*+,;=:]+$`
+
+_Appears in:_
+- [ParentStatus](#parentstatus)
+
+
+
 #### EndpointPickerFailureMode
 
 _Underlying type:_ _string_
@@ -124,7 +150,7 @@ _Appears in:_
 | Field | Description | Default | Validation |
 | --- | --- | --- | --- |
 | `selector` _[LabelSelector](#labelselector)_ | Selector determines which Pods are members of this inference pool.<br />It matches Pods by their labels only within the same namespace; cross-namespace<br />selection is not supported.<br />The structure of this LabelSelector is intentionally simple to be compatible<br />with Kubernetes Service selectors, as some implementations may translate<br />this configuration into a Service resource. |  |  |
-| `targetPorts` _[Port](#port) array_ | TargetPorts defines a list of ports that are exposed by this InferencePool.<br />Currently, the list may only include a single port definition. |  | MaxItems: 1 <br />MinItems: 1 <br /> |
+| `targetPorts` _[Port](#port) array_ | TargetPorts defines a list of ports that are exposed by this InferencePool.<br />Every port will be treated as a distinctive endpoint by EPP,<br />addressable as a 'podIP:portNumber' combination. |  | MaxItems: 8 <br />MinItems: 1 <br /> |
 | `endpointPickerRef` _[EndpointPickerRef](#endpointpickerref)_ | EndpointPickerRef is a reference to the Endpoint Picker extension and its<br />associated configuration. |  |  |
 
 
@@ -294,32 +320,6 @@ _Appears in:_
 
 
 
-#### ParentController
-
-_Underlying type:_ _string_
-
-ParentController is the name of a controller that manages ParentStatus. It must be a domain prefixed
-path.
-
-Valid values include:
-
-* "example.com/bar"
-
-Invalid values include:
-
-* "example.com" - must include path
-* "foo.example.com" - must include path
-
-_Validation:_
-- MaxLength: 253
-- MinLength: 1
-- Pattern: `^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*\/[A-Za-z0-9\/\-._~%!$&'()*+,;=:]+$`
-
-_Appears in:_
-- [ParentStatus](#parentstatus)
-
-
-
 #### ParentReference
 
 
@@ -355,7 +355,7 @@ _Appears in:_
 | --- | --- | --- | --- |
 | `conditions` _[Condition](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.31/#condition-v1-meta) array_ | Conditions is a list of status conditions that provide information about the observed<br />state of the InferencePool. This field is required to be set by the controller that<br />manages the InferencePool.<br />Supported condition types are:<br />* "Accepted"<br />* "ResolvedRefs" |  | MaxItems: 8 <br /> |
 | `parentRef` _[ParentReference](#parentreference)_ | ParentRef is used to identify the parent resource that this status<br />is associated with. It is used to match the InferencePool with the parent<br />resource, such as a Gateway. |  |  |
-| `controllerName` _[ParentController](#parentcontroller)_ | ControllerName is a domain/path string that indicates the name of the controller that<br />wrote this status. This corresponds with the GatewayClass controllerName field when the<br />parentRef references a Gateway kind.<br />Example: "example.net/gateway-controller".<br />The format of this field is DOMAIN "/" PATH, where DOMAIN and PATH are valid Kubernetes names:<br /> https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names<br />Controllers MUST populate this field when writing status. Controllers should ensure that<br />entries to status populated with their ControllerName are cleaned up when they are no<br />longer necessary. |  | MaxLength: 253 <br />MinLength: 1 <br />Pattern: `^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*\/[A-Za-z0-9\/\-._~%!$&'()*+,;=:]+$` <br /> |
+| `controllerName` _[ControllerName](#controllername)_ | ControllerName is a domain/path string that indicates the name of the controller that<br />wrote this status. This corresponds with the GatewayClass controllerName field when the<br />parentRef references a Gateway kind.<br />Example: "example.net/gateway-controller".<br />The format of this field is DOMAIN "/" PATH, where DOMAIN and PATH are valid Kubernetes names:<br /> https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names<br />Controllers MUST populate this field when writing status. Controllers should ensure that<br />entries to status populated with their ControllerName are cleaned up when they are no<br />longer necessary. |  | MaxLength: 253 <br />MinLength: 1 <br />Pattern: `^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*\/[A-Za-z0-9\/\-._~%!$&'()*+,;=:]+$` <br /> |
 
 
 #### Port

client-go/applyconfiguration/apix/v1alpha1/exportingcluster.go

@@ -15,6 +15,21 @@ inference.networking.x-k8s.io API group.
 
 
 
+#### ClusterName
+
+_Underlying type:_ _string_
+
+ClusterName is the name of a cluster that exported the InferencePool.
+
+_Validation:_
+- MaxLength: 253
+- MinLength: 1
+
+_Appears in:_
+- [ExportingCluster](#exportingcluster)
+
+
+
 #### ControllerName
 
 _Underlying type:_ _string_
@@ -44,7 +59,7 @@ _Appears in:_
 
 
 
-ExportingCluster defines a cluster that exported the InferencePool associated to this InferencePoolImport.
+ExportingCluster defines a cluster that exported the InferencePool that backs this InferencePoolImport.
 
 
 
@@ -53,7 +68,7 @@ _Appears in:_
 
 | Field | Description | Default | Validation |
 | --- | --- | --- | --- |
-| `name` _string_ | Name of the exporting cluster (must be unique within the list). |  | Required: \{\} <br /> |
+| `name` _[ClusterName](#clustername)_ | Name of the exporting cluster (must be unique within the list). |  | MaxLength: 253 <br />MinLength: 1 <br />Required: \{\} <br /> |
 
 
 #### ImportController
@@ -90,23 +105,9 @@ InferencePoolImport is the Schema for the InferencePoolImports API.
 | `apiVersion` _string_ | `inference.networking.x-k8s.io/v1alpha1` | | |
 | `kind` _string_ | `InferencePoolImport` | | |
 | `metadata` _[ObjectMeta](https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.31/#objectmeta-v1-meta)_ | Refer to Kubernetes API documentation for fields of `metadata`. |  |  |
-| `spec` _[InferencePoolImportSpec](#inferencepoolimportspec)_ | Spec defines the desired state of the InferencePoolImport. |  |  |
 | `status` _[InferencePoolImportStatus](#inferencepoolimportstatus)_ | Status defines the observed state of the InferencePoolImport. |  |  |
 
 
-#### InferencePoolImportSpec
-
-
-
-InferencePoolImportSpec defines the desired state of the InferencePoolImport.
-
-
-
-_Appears in:_
-- [InferencePoolImport](#inferencepoolimport)
-
-
-
 #### InferencePoolImportStatus