explicit return from test after nil check (#1350)

elevran · web-flow · commit fa834533219d · 2025-08-11T05:01:06.000-07:00
Signed-off-by: Etai Lev Ran &lt;elevran@gmail.com&gt;
diff --git a/pkg/epp/saturationdetector/saturationdetector_test.go b/pkg/epp/saturationdetector/saturationdetector_test.go
@@ -114,6 +114,7 @@ func TestNewDetector(t *testing.T) {
 			detector := NewDetector(LoadConfigFromEnv(), test.datastore, logr.Discard())
 			if detector == nil {
 				t.Fatalf("NewDetector() returned nil detector for valid config")
+				return // explicit return so staticcheck does not warn on potential nil detector below.
 			}
 			if detector.config.QueueDepthThreshold != test.expectedQueueDepthThreshold {
 				t.Errorf("NewDetector() QueueDepthThreshold = %d, want %d", detector.config.QueueDepthThreshold, test.expectedQueueDepthThreshold)

Original file line number	Diff line number	Diff line change
`@@ -114,6 +114,7 @@ func TestNewDetector(t *testing.T) {`
`114`	`114`	`detector := NewDetector(LoadConfigFromEnv(), test.datastore, logr.Discard())`
`115`	`115`	`if detector == nil {`
`116`	`116`	`t.Fatalf("NewDetector() returned nil detector for valid config")`
	`117`	`+ return // explicit return so staticcheck does not warn on potential nil detector below.`
`117`	`118`	`}`
`118`	`119`	`if detector.config.QueueDepthThreshold != test.expectedQueueDepthThreshold {`
`119`	`120`	`t.Errorf("NewDetector() QueueDepthThreshold = %d, want %d", detector.config.QueueDepthThreshold, test.expectedQueueDepthThreshold)`