Skip to content

InferencePoolResolvedRefsCondition Should Assert Default Parent Condition #1407

@danehans

Description

@danehans

What happened:

The InferencePoolResolvedRefsCondition conformance test improperly fails due to the no parent assertion. The API states that the default parent condition should be added back by the managing controller instead of leaving no parent conditions:

type InferencePoolStatus struct {
	// Parents is a list of parent resources (usually Gateways) that are
	// associated with the InferencePool, and the status of the InferencePool with respect to
	// each parent.
	//
	// A maximum of 32 Gateways will be represented in this list. When the list contains
	// `kind: Status, name: default`, it indicates that the InferencePool is not
	// associated with any Gateway and a controller must perform the following:
	//
	//  - Remove the parent when setting the "Accepted" condition.
	//  - Add the parent when the controller will no longer manage the InferencePool
	//    and no other parents exist.
	//
	// +kubebuilder:validation:MaxItems=32
	// +optional
	// +listType=atomic
	Parents []PoolStatus `json:"parent,omitempty"`
}

What you expected to happen:

The test to pass.

How to reproduce it (as minimally and precisely as possible):

Follow the conformance test guide and test kgateway against the main branch.

Anything else we need to know?:

N/A

Environment:

N/A

Metadata

Metadata

Assignees

Labels

kind/bugCategorizes issue or PR as related to a bug.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions