Skip to content

Conversation

@capri-xiyue
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
clean up https://github.com/kubernetes-sigs/gateway-api-inference-extension/pull/1173/files#r2295450243

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 23, 2025
@netlify
Copy link

netlify bot commented Aug 23, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit bed1689
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68ac9c8cc7b2110008ffe6b9
😎 Deploy Preview https://deploy-preview-1444--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 23, 2025
@capri-xiyue
Copy link
Contributor Author

capri-xiyue commented Aug 23, 2025

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2025
Signed-off-by: Xiyue Yu <[email protected]>
@robscott
Copy link
Member

Thanks @capri-xiyue!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2025
@capri-xiyue
Copy link
Contributor Author

/unhold as the community wants to clean up the pointer now.

cc @kfswain @danehans The code is ready to get merged if you are ok to approve it

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2025
@danehans
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: capri-xiyue, danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit c22262e into kubernetes-sigs:main Aug 25, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants