Skip to content

Conversation

@kfswain
Copy link
Collaborator

@kfswain kfswain commented Aug 26, 2025

What type of PR is this?

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Aug 26, 2025
@netlify
Copy link

netlify bot commented Aug 26, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 4b1d372
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68adc9b63f360100089bcfd4
😎 Deploy Preview https://deploy-preview-1466--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 26, 2025
@k8s-ci-robot k8s-ci-robot requested review from ahg-g and danehans August 26, 2025 13:12
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 26, 2025
@nirrozenbaum
Copy link
Contributor

what are your thoughts about adding to the github README.md?
I think most of the experienced users of IGW are not working by following the site. it would be good to warn about possible inconsistencies here and there until we finalize the docs and/or other resources.

@kfswain
Copy link
Collaborator Author

kfswain commented Aug 26, 2025

what are your thoughts about adding to the github README.md? I think most of the experienced users of IGW are not working by following the site. it would be good to warn about possible inconsistencies here and there until we finalize the docs and/or other resources.

Updated, however:

This makes me wonder if the site is used much at all. I would really like to consolidate where we update our docs

@ahg-g
Copy link
Contributor

ahg-g commented Aug 26, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit ae4a24f into kubernetes-sigs:main Aug 26, 2025
9 checks passed
@nirrozenbaum
Copy link
Contributor

This makes me wonder if the site is used much at all. I would really like to consolidate where we update our docs

I do think the site is very useful. it would be great especially when we have docs for pluggable framework architecture with diagrams and explanations for the extension points and the existing plugins.

for such a warning, I feel that GitHub is the right place though (both is even better).

kfswain added a commit to kfswain/llm-instance-gateway that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants