Skip to content

Fix istio getting started guide #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix istio getting started guide #1673

wants to merge 1 commit into from
+91 −82

Conversation

dharaneeshvrd
Copy link

What type of PR is this?

What this PR does / why we need it:
Fix istio getting started guide by reordering the steps since inference pool helm chart requires istio CRDs to be present before installing the chart due to recent change #1381.

Which issue(s) this PR fixes:

Fixes #1649

Does this PR introduce a user-facing change?:

NONE

@netlify Netlify
Copy link

netlify bot commented Oct 2, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit fe5883f
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68e5f6e630cd8b000851779d
😎 Deploy Preview https://deploy-preview-1673--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 2, 2025
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g October 2, 2025 15:29
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dharaneeshvrd
Once this PR has been reviewed and has the lgtm label, please assign danehans for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from danehans October 2, 2025 15:29
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 2, 2025
@dharaneeshvrd
Copy link
Author

/cc @nirrozenbaum
could you please review this fix?

@kfswain
Copy link
Collaborator

kfswain commented Oct 7, 2025

Hi @dharaneeshvrd thanks for the PR. Are we certain this is broken? Looking at the docs it seems like everything is WAI and all other GW implementations have the install step lower down in the guide.

@dharaneeshvrd
Copy link
Author

@kfswain Yes currently all GW implementations are having the install step lower down the guide but it seems due to #1381 this recent change, inferencepool helm chart for istio provider requires istio's DestinationRule CRD to be present first. Hence for istio alone moved the installation step before installing the inferencepool helm chart like its being requested in the issue #1649.

@nirrozenbaum
Copy link
Contributor

@kfswain yup, this is certain. see issue #1649 which I opened after following the quickstart guide and hit that issue.

@dharaneeshvrd I think the current change is not the ideal one.
after this change - the section that is called Deploy the InferencePool and Endpoint Picker Extension is now describing how to install Istio using istioctl.

I was thinking about adding a new Sub-Section like Install Gateway which should include the installation of the specific gateway CRDs (and most Gateways also describe requirement for installing Gateway API CRDs).
so the idea is to make a separation between CRDs installation and actual deployment.
(it's kinda the same idea that we install Inference Extension CRDs in one sub-section, and deploy it in the next sub section).

additionally, when doing this change please pay attention to numbering, cause in current change that was missing (see screenshot below):
image

@dharaneeshvrd
Copy link
Author

Ok If I understood correctly, the guide would have following sections.
Deploy Sample Model Server
Install the Inference Extension CRDs
Install Gateway - New section to add instruction to install Gateway API CRDs and provider specific gateway(CRD & GW itself)
Deploy the InferencePool and Endpoint Picker Extension
Deploy an Inference Gateway - Instruction to deploy Inference Gateway & HttpRoute ...
Remainig section continues as is ...

Hope I can continue with the changes described above.

@nirrozenbaum
Copy link
Contributor

Ok If I understood correctly, the guide would have following sections. Deploy Sample Model Server Install the Inference Extension CRDs Install Gateway - New section to add instruction to install Gateway API CRDs and provider specific gateway(CRD & GW itself) Deploy the InferencePool and Endpoint Picker Extension Deploy an Inference Gateway - Instruction to deploy Inference Gateway & HttpRoute ... Remainig section continues as is ...

Hope I can continue with the changes described above.

yeah, that sounds good 👍🏻

@dharaneeshvrd dharaneeshvrd force-pushed the fix-istio-getting-started-guide branch from af9a1d5 to 1a8e395 Compare October 8, 2025 05:26
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 8, 2025
@dharaneeshvrd dharaneeshvrd force-pushed the fix-istio-getting-started-guide branch from 1a8e395 to 17151c8 Compare October 8, 2025 05:29
@dharaneeshvrd
Add Install Gateway section in Getting Started guide
fe5883f 
- Move instructions from the Deploy an Inference Gateway section describing installation of Gateway API CRDs and provider specific GWs

Signed-off-by: Dharaneeshwaran Ravichandran <[email protected]>
@dharaneeshvrd dharaneeshvrd force-pushed the fix-istio-getting-started-guide branch from 17151c8 to fe5883f Compare October 8, 2025 05:30
@k8s-ci-robot
Copy link
Contributor

@dharaneeshvrd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-inference-extension-test-unit-main fe5883f link true /test pull-gateway-api-inference-extension-test-unit-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dharaneeshvrd
Copy link
Author

@nirrozenbaum Could you please review the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@danehans danehans Awaiting requested review from danehans

@nirrozenbaum nirrozenbaum Awaiting requested review from nirrozenbaum

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

quickstart with Istio fails due to wrong order of steps
4 participants
@dharaneeshvrd @k8s-ci-robot @kfswain @nirrozenbaum