-
Notifications
You must be signed in to change notification settings - Fork 195
feat(conformance): add conformance test for verifying x-gateway-destination-endpoint-served
#1862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@zetxqx: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
8a653d2 to
1708386
Compare
|
/assign @nirrozenbaum @danehans @robscott |
1708386 to
bf6a026
Compare
bf6a026 to
e7a278e
Compare
e7a278e to
88f2055
Compare
|
/unhold ready for review now. |
|
/approve |
robscott
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zetxqx!
| Description: "A conformance test to verify that the gateway correctly reports the endpoint that served the request.", | ||
| Manifests: []string{"tests/gateway_destination_endpoint_served.yaml"}, | ||
| Features: []features.FeatureName{ | ||
| features.FeatureName("SupportInferencePool"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like something that needs a const (similar to SupportGateway)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll have a separate PR for this change to fix #863
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kfswain, robscott, zetxqx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind test
/area conformance-test
What this PR does / why we need it:
A conformance test to verify that the gateway correctly reports the endpoint that served the request.
This PR is based on a previous PR #1855 .
verified with GKE
Result:
Which issue(s) this PR fixes:
Fixes #1670
Does this PR introduce a user-facing change?: