Skip to content

Added crd validation ci workflow. #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Added crd validation ci workflow. #1879

wants to merge 7 commits into from
+51 −0

Conversation

@bexxmodd
Copy link
Contributor

@bexxmodd bexxmodd commented Nov 19, 2025

/kind test

What this PR does / why we need it:
This adds a CRD validation CI workflow

Which issue(s) this PR fixes:

Fixes #1842

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 19, 2025

@bexxmodd: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

/kind test

What this PR does / why we need it:
This adds a CRD validation CI workflow

Which issue(s) this PR fixes:

Fixes #1842

Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bexxmodd
Once this PR has been reviewed and has the lgtm label, please assign nirrozenbaum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from ahg-g November 19, 2025 05:01
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 19, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 19, 2025
@netlify
Copy link

netlify bot commented Nov 19, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 5e0bdab
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/691d5a667f76d50008b4e3e4
😎 Deploy Preview https://deploy-preview-1879--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@bexxmodd
Copy link
Contributor Author

bexxmodd commented Nov 19, 2025

/cc @danehans

@kfswain
Copy link
Collaborator

kfswain commented Nov 19, 2025

Thanks Beka!!

Is this different from: https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/53080981077a431822c383616789a05c4bcc0ce5/Makefile#L179C9-L179C20
?

@bexxmodd
Copy link
Contributor Author

bexxmodd commented Nov 20, 2025

Thanks Beka!!

Is this different from: https://github.com/kubernetes-sigs/gateway-api-inference-extension/blob/53080981077a431822c383616789a05c4bcc0ce5/Makefile#L179C9-L179C20 ?

Yeah, looking at the shell script it invokes, it looks like it does CRD validation against the defined schema, while crdify analyzes changes to the CRD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@robscott robscott Awaiting requested review from robscott

@danehans danehans Awaiting requested review from danehans

Assignees

No one assigned

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: Add Tooling to Check for Incompatible CRD Changes

3 participants

@bexxmodd @k8s-ci-robot @kfswain