Merge pull request #2623 from mlavacca/fix-conformance-test-port-extended

k8s-ci-robot · web-flow · commit 087d3ab59cef · 2023-12-01T00:51:57.000+01:00
fix(conformance): `parentRef` port is extended
diff --git a/conformance/tests/httproute-invalid-parentref-section-name-not-matching-port.go b/conformance/tests/httproute-invalid-parentref-section-name-not-matching-port.go
@@ -37,6 +37,7 @@ var HTTPRouteInvalidParentRefSectionNameNotMatchingPort = suite.ConformanceTest{
 	Features: []suite.SupportedFeature{
 		suite.SupportGateway,
 		suite.SupportHTTPRoute,
+		suite.SupportHTTPRouteParentRefPort,
 	},
 	Manifests: []string{"tests/httproute-invalid-parentref-section-name-not-matching-port.yaml"},
 	Test: func(t *testing.T, suite *suite.ConformanceTestSuite) {
diff --git a/conformance/utils/suite/features.go b/conformance/utils/suite/features.go
@@ -133,6 +133,9 @@ const (
 
 	// This option indicates support for HTTPRoute backendRequest timeouts (extended conformance).
 	SupportHTTPRouteBackendTimeout SupportedFeature = "HTTPRouteBackendTimeout"
+
+	// This option indicates support for HTTPRoute parentRef port (extended conformance).
+	SupportHTTPRouteParentRefPort SupportedFeature = "HTTPRouteParentRefPort"
 )
 
 // HTTPRouteExtendedFeatures includes all the supported features for HTTPRoute
@@ -151,6 +154,7 @@ var HTTPRouteExtendedFeatures = sets.New(
 	SupportHTTPRouteRequestMultipleMirrors,
 	SupportHTTPRouteRequestTimeout,
 	SupportHTTPRouteBackendTimeout,
+	SupportHTTPRouteParentRefPort,
 )
 
 // -----------------------------------------------------------------------------

Original file line number	Diff line number	Diff line change
`@@ -133,6 +133,9 @@ const (`
`133`	`133`
`134`	`134`	`// This option indicates support for HTTPRoute backendRequest timeouts (extended conformance).`
`135`	`135`	`SupportHTTPRouteBackendTimeout SupportedFeature = "HTTPRouteBackendTimeout"`
	`136`	`+`
	`137`	`+ // This option indicates support for HTTPRoute parentRef port (extended conformance).`
	`138`	`+ SupportHTTPRouteParentRefPort SupportedFeature = "HTTPRouteParentRefPort"`
`136`	`139`	`)`
`137`	`140`
`138`	`141`	`// HTTPRouteExtendedFeatures includes all the supported features for HTTPRoute`
`@@ -151,6 +154,7 @@ var HTTPRouteExtendedFeatures = sets.New(`
`151`	`154`	`SupportHTTPRouteRequestMultipleMirrors,`
`152`	`155`	`SupportHTTPRouteRequestTimeout,`
`153`	`156`	`SupportHTTPRouteBackendTimeout,`
	`157`	`+ SupportHTTPRouteParentRefPort,`
`154`	`158`	`)`
`155`	`159`
`156`	`160`	`// -----------------------------------------------------------------------------`