Skip to content

Commit 0a48c44

Browse files
kflynnk8s-ci-robot
authored andcommitted
chore: Address more review feedback
Signed-off-by: Flynn <[email protected]>
1 parent d866750 commit 0a48c44

File tree

6 files changed

+15
-111
lines changed

6 files changed

+15
-111
lines changed

apis/v1/gateway_types.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,8 @@ type GatewaySpec struct {
313313
// recommend not using this just because it seems convenient, and instead
314314
// stick to direct Route attachment.
315315
//
316-
// +optional <gateway:experimental>
316+
// +optional
317+
// <gateway:experimental>
317318
DefaultScope GatewayDefaultScope `json:"defaultScope,omitempty"`
318319
}
319320

apis/v1/shared_types.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,9 @@ type ParentReference struct {
158158
// GatewayDefaultScope defines the set of default scopes that a Gateway
159159
// can claim, for use in any Route type. At present the only supported
160160
// scopes are "All" and "None". "None" is a special scope which
161-
// explicitly means that the Route MUST NOT be defaulted.
161+
// explicitly means that the Route MUST NOT attached to any default
162+
// Gateway.
163+
//
162164
// +kubebuilder:validation:Enum=All;None
163165
type GatewayDefaultScope string
164166

@@ -260,7 +262,8 @@ type CommonRouteSpec struct {
260262
// example, a Route with specific security requirements should almost
261263
// certainly not use a default Gateway.
262264
//
263-
// +optional <gateway:experimental>
265+
// +optional
266+
// <gateway:experimental>
264267
UseDefaultGateways GatewayDefaultScope `json:"useDefaultGateways,omitempty"`
265268
}
266269

config/crd/standard/gateway.networking.k8s.io_gateways.yaml

Lines changed: 0 additions & 46 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/standard/gateway.networking.k8s.io_grpcroutes.yaml

Lines changed: 0 additions & 18 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/standard/gateway.networking.k8s.io_httproutes.yaml

Lines changed: 0 additions & 36 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)