Skip to content

Commit 1b18b46

Browse files
committed
rename GatewayTLSConfig to ListenerTLSConfig
1 parent d94294e commit 1b18b46

File tree

15 files changed

+373
-177
lines changed

15 files changed

+373
-177
lines changed

apis/v1/gateway_types.go

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -693,8 +693,12 @@ type FrontendTLSValidation struct {
693693
// - AllowValidOnly: In this mode, the gateway will accept connections only if
694694
// the client presents a valid certificate. This certificate must successfully
695695
// pass validation against the CA certificates specified in `CACertificateRefs`.
696-
// - AllowInvalidOrMissingCert: In this mode, the gateway will accept
697-
// connections even if the client certificate is not presented or fails verification.
696+
// - AllowInsecureFallback: In this mode, the gateway will accept connections
697+
// even if the client certificate is not presented or fails verification.
698+
//
699+
// This approach delegates client authorization to the backend and introduce
700+
// a significant security risk. It should be used in testing environments or
701+
// on a temporary basis in non-testing environments.
698702
//
699703
// Defaults to AllowValidOnly.
700704
//
@@ -707,17 +711,17 @@ type FrontendTLSValidation struct {
707711

708712
// FrontendValidationModeType type defines how a Gateway validates client certificates.
709713
//
710-
// +kubebuilder:validation:Enum=AllowValidOnly;AllowInvalidOrMissingCert
714+
// +kubebuilder:validation:Enum=AllowValidOnly;AllowInsecureFallback
711715
type FrontendValidationModeType string
712716

713717
const (
714718
// AllowValidOnly indicates that a client certificate is required
715719
// during the TLS handshake and MUST pass validation.
716720
AllowValidOnly FrontendValidationModeType = "AllowValidOnly"
717721

718-
// AllowInvalidOrMissingCert indicates that a client certificate may not be
722+
// AllowInsecureFallback indicates that a client certificate may not be
719723
// presented during the handshake or the validation against CA certificates may fail.
720-
AllowInvalidOrMissingCert FrontendValidationModeType = "AllowInvalidOrMissingCert"
724+
AllowInsecureFallback FrontendValidationModeType = "AllowInsecureFallback"
721725
)
722726

723727
// AllowedRoutes defines which Routes may be attached to this Listener.

apis/v1/zz_generated.deepcopy.go

Lines changed: 35 additions & 40 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

apis/v1beta1/gateway_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,9 +88,9 @@ type Listener = v1.Listener
8888
// +k8s:deepcopy-gen=false
8989
type ProtocolType = v1.ProtocolType
9090

91-
// GatewayTLSConfig describes a TLS configuration.
91+
// ListenerTLSConfig describes a TLS configuration.
9292
// +k8s:deepcopy-gen=false
93-
type GatewayTLSConfig = v1.GatewayTLSConfig
93+
type ListenerTLSConfig = v1.ListenerTLSConfig
9494

9595
// TLSModeType type defines how a Gateway handles TLS sessions.
9696
//

apisx/v1alpha1/shared_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ type (
2525
// +k8s:deepcopy-gen=false
2626
AllowedRoutes = v1.AllowedRoutes
2727
// +k8s:deepcopy-gen=false
28-
GatewayTLSConfig = v1.GatewayTLSConfig
28+
ListenerTLSConfig = v1.ListenerTLSConfig
2929
// +k8s:deepcopy-gen=false
3030
Group = v1.Group
3131
// +k8s:deepcopy-gen=false

apisx/v1alpha1/xlistenerset_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,14 +179,14 @@ type ListenerEntry struct {
179179
// the Protocol field is "HTTPS" or "TLS". It is invalid to set this field
180180
// if the Protocol field is "HTTP", "TCP", or "UDP".
181181
//
182-
// The association of SNIs to Certificate defined in GatewayTLSConfig is
182+
// The association of SNIs to Certificate defined in ListenerTLSConfig is
183183
// defined based on the Hostname field for this listener.
184184
//
185185
// The GatewayClass MUST use the longest matching SNI out of all
186186
// available certificates for any TLS handshake.
187187
//
188188
// +optional
189-
TLS *GatewayTLSConfig `json:"tls,omitempty"`
189+
TLS *ListenerTLSConfig `json:"tls,omitempty"`
190190

191191
// AllowedRoutes defines the types of routes that MAY be attached to a
192192
// Listener and the trusted namespaces where those Route resources MAY be

apisx/v1alpha1/zz_generated.deepcopy.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

applyconfiguration/apis/v1/listener.go

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

applyconfiguration/apis/v1/listenertlsconfig.go

Lines changed: 72 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

applyconfiguration/apisx/v1alpha1/listenerentry.go

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

applyconfiguration/internal/internal.go

Lines changed: 19 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)