Skip to content

Commit 1da7c37

Browse files
authored
prevent controller-runtime stack traces logger (#4054)
1 parent 59a1a4e commit 1da7c37

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

conformance/conformance.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,18 @@ import (
3636
clientset "k8s.io/client-go/kubernetes"
3737
"sigs.k8s.io/controller-runtime/pkg/client"
3838
"sigs.k8s.io/controller-runtime/pkg/client/config"
39+
"sigs.k8s.io/controller-runtime/pkg/log"
40+
"sigs.k8s.io/controller-runtime/pkg/log/zap"
3941
"sigs.k8s.io/yaml"
4042
)
4143

4244
// DefaultOptions will parse command line flags to populate a
4345
// ConformanceOptions struct. It will also initialize the various clients
4446
// required by the tests.
4547
func DefaultOptions(t *testing.T) suite.ConformanceOptions {
48+
// This line prevents controller-runtime from complaining about log.SetLogger never being called
49+
log.SetLogger(zap.New(zap.WriteTo(os.Stdout), zap.UseDevMode(true)))
50+
4651
cfg, err := config.GetConfig()
4752
require.NoError(t, err, "error loading Kubernetes config")
4853
clientOptions := client.Options{}

go.mod

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ require (
3535
github.com/fatih/color v1.18.0 // indirect
3636
github.com/fxamacker/cbor/v2 v2.9.0 // indirect
3737
github.com/go-logr/logr v1.4.3 // indirect
38+
github.com/go-logr/zapr v1.3.0 // indirect
3839
github.com/go-openapi/jsonpointer v0.21.2 // indirect
3940
github.com/go-openapi/jsonreference v0.21.0 // indirect
4041
github.com/go-openapi/swag v0.23.1 // indirect

0 commit comments

Comments
 (0)