Skip to content

Commit 35fe25d

Browse files
Allow an implementation to use listed order for HTTPRouteFilter in a route-rule (#2687)
* Allow an implementation to use listed order for HTTPRouteFilter in a route-rule * ran 'make generate' to regenerate the modified resurce definitions * Specify stricter mode with "SHOULD" using the RFC 2119 definition Co-authored-by: Rob Scott <[email protected]> * use MUST instead of should for RFC2119 and remove extra spaces * ran 'make generate' to regenerate the CRDs * Change "in only" to "if only" Co-authored-by: Rob Scott <[email protected]> * Change "(s)" to "s" Co-authored-by: Rob Scott <[email protected]> * commit regenerated CRDs/comments --------- Co-authored-by: Rob Scott <[email protected]>
1 parent 9a663ba commit 35fe25d

File tree

3 files changed

+117
-70
lines changed

3 files changed

+117
-70
lines changed

apis/v1/httproute_types.go

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,19 @@ type HTTPRouteRule struct {
196196
// Filters define the filters that are applied to requests that match
197197
// this rule.
198198
//
199-
// The effects of ordering of multiple behaviors are currently unspecified.
200-
// This can change in the future based on feedback during the alpha stage.
199+
// Wherever possible, implementations SHOULD implement filters in the order
200+
// they are specified.
201+
//
202+
// Implementations MAY choose to implement this ordering strictly, rejecting
203+
// any combination or order of filters that can not be supported. If implementations
204+
// choose a strict interpretation of filter ordering, they MUST clearly document
205+
// that behavior.
206+
//
207+
// To reject an invalid combination or order of filters, implementations SHOULD
208+
// consider the Route Rules with this configuration invalid. If all Route Rules
209+
// in a Route are invalid, the entire Route would be considered invalid. If only
210+
// a portion of Route Rules are invalid, implementations MUST set the
211+
// "PartiallyInvalid" condition for the Route.
201212
//
202213
// Conformance-levels at this level are defined based on the type of filter:
203214
//

config/crd/experimental/gateway.networking.k8s.io_httproutes.yaml

Lines changed: 52 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

config/crd/standard/gateway.networking.k8s.io_httproutes.yaml

Lines changed: 52 additions & 34 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)