add support for hostname address in conformance

snehachhabria · snehachhabria · commit 6f9e99272672 · 2023-11-30T13:37:57.000-08:00
diff --git a/conformance/utils/kubernetes/helpers.go b/conformance/utils/kubernetes/helpers.go
@@ -409,9 +409,8 @@ func WaitForGatewayAddress(t *testing.T, client client.Client, timeoutConfig con
 
 		port = strconv.FormatInt(int64(gw.Spec.Listeners[0].Port), 10)
 
-		// TODO: Support more than IPAddress
 		for _, address := range gw.Status.Addresses {
-			if address.Type != nil && *address.Type == gatewayv1.IPAddressType {
+			if address.Type != nil && (*address.Type == gatewayv1.IPAddressType || *address.Type == v1alpha2.HostnameAddressType) {
 				ipAddr = address.Value
 				return true, nil
 			}

Original file line number	Diff line number	Diff line change
`@@ -409,9 +409,8 @@ func WaitForGatewayAddress(t *testing.T, client client.Client, timeoutConfig con`
`409`	`409`
`410`	`410`	`port = strconv.FormatInt(int64(gw.Spec.Listeners[0].Port), 10)`
`411`	`411`
`412`		`- // TODO: Support more than IPAddress`
`413`	`412`	`for _, address := range gw.Status.Addresses {`
`414`		`- if address.Type != nil && *address.Type == gatewayv1.IPAddressType {`
	`413`	`+ if address.Type != nil && (address.Type == gatewayv1.IPAddressType \|\| address.Type == v1alpha2.HostnameAddressType) {`
`415`	`414`	`ipAddr = address.Value`
`416`	`415`	`return true, nil`
`417`	`416`	`}`