Skip to content

Commit a2bbf16

Browse files
kflynnk8s-ci-robot
authored andcommitted
Review feedback from Rob Scott
These are nits, thanks Rob! Co-authored-by: Rob Scott <[email protected]> Signed-off-by: Flynn <[email protected]>
1 parent 93b5026 commit a2bbf16

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

apis/v1/gateway_types.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ type GatewaySpec struct {
299299
// meaning it will dynamically and implicitly have Routes (e.g. HTTPRoute)
300300
// attached to it, according to the scope configured here.
301301
//
302-
// If unset or set to the empty string `""` (the default), the Gateway
302+
// If unset or set to an empty string `""` (the default), the Gateway
303303
// will not act as a default Gateway; if set, the Gateway will claim any
304304
// Route with a matching scope set in its UseDefaultGateway field, subject
305305
// to the usual rules about which routes the Gateway can attach to.
@@ -311,7 +311,7 @@ type GatewaySpec struct {
311311
// control of the scope (e.g. namespace) with tight controls and checks on
312312
// what kind of workloads and Routes get added in that scope, we strongly
313313
// recommend not using this just because it seems convenient, and instead
314-
// stick to explicit Route attachment.
314+
// stick to direct Route attachment.
315315
//
316316
// +optional <gateway:experimental>
317317
DefaultScope GatewayDefaultScope `json:"defaultScope,omitempty"`

apis/v1/shared_types.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,6 @@ type CommonRouteSpec struct {
253253
// appropriate to request a default Gateway for a given Route -- for
254254
// example, a Route with specific security requirements should almost certainly
255255
// not use a default Gateway.
256-
// not use a default Gateway.
257256
//
258257
// +optional <gateway:experimental>
259258
UseDefaultGateway GatewayDefaultScope `json:"useDefaultGateway,omitempty"`

0 commit comments

Comments
 (0)