Skip to content

Commit b40893e

Browse files
committed
adding missing supportedFeatures to kubebuilder validation
1 parent 916d8c4 commit b40893e

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

.github/workflows/supported_features.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ on:
33
pull_request:
44
branches:
55
- main
6-
- master
76
paths:
87
- 'conformance/utils/suite/**'
98
jobs:

apis/v1/gatewayclass_types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,5 +266,5 @@ type GatewayClassList struct {
266266

267267
// SupportedFeature is used to describe distinct features that are covered by
268268
// conformance tests.
269-
// +kubebuilder:validation:Enum=Gateway;GatewayPort8080;GatewayStaticAddresses;HTTPRoute;HTTPRouteDestinationPortMatching;HTTPRouteHostRewrite;HTTPRouteMethodMatching;HTTPRoutePathRedirect;HTTPRoutePathRewrite;HTTPRoutePortRedirect;HTTPRouteQueryParamMatching;HTTPRouteRequestMirror;HTTPRouteRequestMultipleMirrors;HTTPRouteResponseHeaderModification;HTTPRouteSchemeRedirect;Mesh;ReferenceGrant;TLSRoute
269+
// +kubebuilder:validation:Enum=Gateway;GatewayPort8080;GatewayStaticAddresses;HTTPRoute;HTTPRouteBackendProtocolH2C;HTTPRouteBackendProtocolWebSocket;HTTPRouteBackendTimeout;HTTPRouteDestinationPortMatching;HTTPRouteHostRewrite;HTTPRouteMethodMatching;HTTPRouteParentRefPort;HTTPRoutePathRedirect;HTTPRoutePathRewrite;HTTPRoutePortRedirect;HTTPRouteQueryParamMatching;HTTPRouteRequestMirror;HTTPRouteRequestMultipleMirrors;HTTPRouteRequestTimeout;HTTPRouteResponseHeaderModification;HTTPRouteSchemeRedirect;Mesh;ReferenceGrant;TLSRoute
270270
type SupportedFeature string

conformance/utils/suite/features.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ var MeshCoreFeatures = sets.New(
217217

218218
// AllFeatures contains all the supported features and can be used to run all
219219
// conformance tests with `all-features` flag.
220-
// asd
220+
//
221221
// NOTE: as new feature sets are added they should be inserted into this set.
222222
var AllFeatures = sets.New[SupportedFeature]().
223223
Insert(GatewayExtendedFeatures.UnsortedList()...).

0 commit comments

Comments
 (0)