address review's comments

Signed-off-by: Mattia Lavacca <[email protected]>

Author: mlavacca

conformance/utils/suite/experimental_reports.go

@@ -187,21 +187,21 @@ func isTestExtended(profile ConformanceProfile, test ConformanceTest) bool {
 }
 
 // buildSummary creates a human-readable message about each profile's test outcomes.
-func buildSummary(report confv1a1.ProfileReport) string {
-	reportMessage := fmt.Sprintf("Core tests %s", buildReportMessage(report.Core))
+func buildSummary(report confv1a1.ProfileReport) (reportSummary string) {
+	reportSummary = fmt.Sprintf("Core tests %s", buildReportSummary(report.Core))
 	if report.Extended != nil {
-		reportMessage = fmt.Sprintf("%s. Extended tests %s", reportMessage, buildReportMessage(report.Extended.Status))
+		reportSummary = fmt.Sprintf("%s. Extended tests %s", reportSummary, buildReportSummary(report.Extended.Status))
 	}
-	return fmt.Sprintf("%s.", reportMessage)
+	return fmt.Sprintf("%s.", reportSummary)
 }
 
-func buildReportMessage(status confv1a1.Status) string {
+func buildReportSummary(status confv1a1.Status) string {
 	var message string
 	switch status.Result {
 	case confv1a1.Success:
-		message = "succedeed"
+		message = "succeeded"
 	case confv1a1.Partial:
-		message = fmt.Sprintf("partially succedeed with %d test skips", status.Statistics.Skipped)
+		message = fmt.Sprintf("partially succeeded with %d test skips", status.Statistics.Skipped)
 	case confv1a1.Failure:
 		message = fmt.Sprintf("failed with %d test failures", status.Statistics.Failed)
 	}

conformance/utils/suite/experimental_reports_test.go

@@ -45,7 +45,7 @@ func TestBuildSummary(t *testing.T) {
 			expectedSummary: "Core tests failed with 3 test failures.",
 		},
 		{
-			name: "core tests succedeed, extended tests failed",
+			name: "core tests succeeded, extended tests failed",
 			report: confv1a1.ProfileReport{
 				Name: string(HTTPConformanceProfileName),
 				Core: confv1a1.Status{
@@ -64,10 +64,10 @@ func TestBuildSummary(t *testing.T) {
 					},
 				},
 			},
-			expectedSummary: "Core tests succedeed. Extended tests failed with 1 test failures.",
+			expectedSummary: "Core tests succeeded. Extended tests failed with 1 test failures.",
 		},
 		{
-			name: "core tests partially succedeed, extended tests succedeed",
+			name: "core tests partially succeeded, extended tests succeeded",
 			report: confv1a1.ProfileReport{
 				Name: string(HTTPConformanceProfileName),
 				Core: confv1a1.Status{
@@ -86,10 +86,10 @@ func TestBuildSummary(t *testing.T) {
 					},
 				},
 			},
-			expectedSummary: "Core tests partially succedeed with 2 test skips. Extended tests succedeed.",
+			expectedSummary: "Core tests partially succeeded with 2 test skips. Extended tests succeeded.",
 		},
 		{
-			name: "core tests succedeed, extended tests partially succedeed",
+			name: "core tests succeeded, extended tests partially succeeded",
 			report: confv1a1.ProfileReport{
 				Name: string(HTTPConformanceProfileName),
 				Core: confv1a1.Status{
@@ -108,7 +108,7 @@ func TestBuildSummary(t *testing.T) {
 					},
 				},
 			},
-			expectedSummary: "Core tests succedeed. Extended tests partially succedeed with 1 test skips.",
+			expectedSummary: "Core tests succeeded. Extended tests partially succeeded with 1 test skips.",
 		},
 	}