Skip to content

Commit ba348af

Browse files
committed
Fix some reviews
1 parent 8e325ad commit ba348af

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

geps/gep-1713/index.md

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,7 @@ spec:
453453
sectionName: second
454454
```
455455

456-
Routes MUST be able to attach to a `ListenerSet` and it's parent `Gateway` by having multiple `parentRefs` eg:
456+
If routes MUST attach to a `ListenerSet` and its parent `Gateway`, it MUST have multiple `parentRefs` eg:
457457

458458
```yaml
459459
apiVersion: gateway.networking.k8s.io/v1
@@ -510,7 +510,7 @@ metadata:
510510
name: httproute-example
511511
spec:
512512
parentRefs:
513-
- name: some-workload-listeners
513+
- name: parent-gateway
514514
kind: Gateway
515515
sectionName: foo
516516
```
@@ -579,11 +579,11 @@ kind: Gateway
579579
.....
580580
spec:
581581
listeners:
582-
- name: foo
582+
- name: foo2
583583
hostname: foo.com
584584
protocol: HTTP
585585
port: 80
586-
- name: foo1
586+
- name: foo3
587587
hostname: foo1.com
588588
protocol: HTTP
589589
port: 80
@@ -750,8 +750,12 @@ status:
750750
protocol: HTTPS
751751
port: 443
752752
conditions:
753+
- message: ListenerSet has conflicts with Gateway 'infra/parent-gateway'
754+
reason: ParentNotAccepted
755+
status: "False"
756+
type: Accepted
753757
- message: ListenerSet has conflicts with Gateway 'infra/parent-gateway'
754-
reason: Conflicted
758+
reason: ListenerConflict
755759
status: "True"
756760
type: Conflicted
757761
```
@@ -834,7 +838,7 @@ status:
834838
port: 443
835839
conditions:
836840
- message: ListenerSet has conflicts with other listeners attached to the same Gateway
837-
reason: Conflicted
841+
reason: ListenerConflict
838842
status: "True"
839843
type: Conflicted
840844
---

0 commit comments

Comments
 (0)