Skip to content

Commit cb485fa

Browse files
committed
Fix some review findings
1 parent 46880e8 commit cb485fa

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

geps/gep-1713/index.md

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -340,9 +340,9 @@ type ParentGatewayReference struct {
340340

341341
### YAML
342342

343-
The following example shows a `Gateway` with an HTTP listener and two child HTTPS `ListenerSets` with unique hostnames and certificates.
344-
343+
The following example shows a `Gateway` with an HTTP listener and two child HTTPS `ListenerSets` with unique hostnames and certificates.
345344
Only `ListenerSets` from the same namespace of the `Gateway` will be accepted:
345+
346346
```yaml
347347
apiVersion: gateway.networking.k8s.io/v1
348348
kind: Gateway
@@ -439,8 +439,6 @@ spec:
439439

440440
Routes MUST be able to specify a `ListenerSet` as a `parentRef`. Routes can use `sectionName`/`port` fields in `ParentReference` to help target a specific listener. If no listener is targeted (`sectionName`/`port` are unset) then the Route attaches to all the listeners in the `ListenerSet`.
441441

442-
Routes MUST be able to attach to a `ListenerSet` and it's parent `Gateway` by having multiple `parentRefs` eg:
443-
444442
```yaml
445443
apiVersion: gateway.networking.k8s.io/v1
446444
kind: HTTPRoute
@@ -453,7 +451,8 @@ spec:
453451
sectionName: second
454452
```
455453

456-
To attach to listeners in both a `Gateway` and `ListenerSet` the route MUST have two `parentRefs`:
454+
Routes MUST be able to attach to a `ListenerSet` and it's parent `Gateway` by having multiple `parentRefs` eg:
455+
457456
```yaml
458457
apiVersion: gateway.networking.k8s.io/v1
459458
kind: HTTPRoute
@@ -599,7 +598,7 @@ spec:
599598
hostname: www.something.tld
600599
protocol: HTTPS
601600
port: 443
602-
tls:
601+
tls:
603602
mode: Terminate
604603
certificateRefs:
605604
- kind: Secret
@@ -630,8 +629,9 @@ spec:
630629
```
631630

632631
The ListenerSet `user-listenerset` should be marked as Conflicted, as the `parent-gateway`
633-
have a listener definition called `foo` that conflicts with the ListenetSet definition
634-
called `myapp`, as the following:
632+
has a listener definition called `foo` that conflicts with the ListenetSet definition
633+
called `myapp`. The conflict happens because hostname is the same on both `ListenerSet`
634+
but they use different termination TLS certificates:
635635

636636
```yaml
637637
apiVersion: gateway.networking.x-k8s.io/v1alpha1
@@ -646,7 +646,7 @@ status:
646646
hostname: www.something.tld
647647
protocol: HTTPS
648648
port: 443
649-
conditions:
649+
conditions:
650650
- message: ListenerSet has conflicts with Gateway 'infra/parent-gateway'
651651
reason: Conflicted
652652
status: "True"
@@ -729,8 +729,8 @@ status:
729729
hostname: www.something.tld
730730
protocol: HTTPS
731731
port: 443
732-
conditions:
733-
- message: ListenerSet has conflicts with other listeners attached to the same Gateway
732+
conditions:
733+
- message: ListenerSet has conflicts with other listeners attached to the same Gateway
734734
reason: Conflicted
735735
status: "True"
736736
type: Conflicted
@@ -747,7 +747,7 @@ status:
747747
hostname: www.something.tld
748748
protocol: HTTPS
749749
port: 443
750-
conditions:
750+
conditions:
751751
- reason: Accepted
752752
status: "True"
753753
type: Accepted

0 commit comments

Comments
 (0)