Skip to content

Commit ee9e957

Browse files
aligning GatewayCoreFeatures to be as the rest of the CoreFeatures (#2710)
* aligning GatewayCoreFeatures to be as the rest of the CoreFeatures I checked and we are not breaking anyone https://github.com/search?q=GatewayExtendedFeatures&type=code * fix indent * clarify extended features sets dont include core features
1 parent 2ac95e4 commit ee9e957

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

conformance/utils/suite/features.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,12 +56,12 @@ const (
5656
SupportGatewayStaticAddresses SupportedFeature = "GatewayStaticAddresses"
5757
)
5858

59-
// StandardExtendedFeatures are extra generic features that implementations may
60-
// choose to support as an opt-in.
59+
// GatewayExtendedFeatures are extra generic features that implementations may
60+
// choose to support as an opt-in. This does not include any Core Features.
6161
var GatewayExtendedFeatures = sets.New(
6262
SupportGatewayPort8080,
6363
SupportGatewayStaticAddresses,
64-
).Insert(GatewayCoreFeatures.UnsortedList()...)
64+
)
6565

6666
// -----------------------------------------------------------------------------
6767
// Features - ReferenceGrant Conformance (Core)
@@ -138,9 +138,9 @@ const (
138138
SupportHTTPRouteParentRefPort SupportedFeature = "HTTPRouteParentRefPort"
139139
)
140140

141-
// HTTPRouteExtendedFeatures includes all the supported features for HTTPRoute
142-
// conformance and can be used to opt-in to run all HTTPRoute tests, including
143-
// extended features.
141+
// HTTPRouteExtendedFeatures includes all extended features for HTTPRoute
142+
// conformance and can be used to opt-in to run all HTTPRoute extended features tests.
143+
// This does not include any Core Features.
144144
var HTTPRouteExtendedFeatures = sets.New(
145145
SupportHTTPRouteQueryParamMatching,
146146
SupportHTTPRouteMethodMatching,
@@ -220,6 +220,7 @@ var MeshCoreFeatures = sets.New(
220220
//
221221
// NOTE: as new feature sets are added they should be inserted into this set.
222222
var AllFeatures = sets.New[SupportedFeature]().
223+
Insert(GatewayCoreFeatures.UnsortedList()...).
223224
Insert(GatewayExtendedFeatures.UnsortedList()...).
224225
Insert(ReferenceGrantCoreFeatures.UnsortedList()...).
225226
Insert(HTTPRouteCoreFeatures.UnsortedList()...).

0 commit comments

Comments
 (0)