Merge pull request #2262 from gauravkghildiyal/add-cel-validation-to-presubmit

Add CEL validation to presubmit

Author: k8s-ci-robot

hack/cel-validation/gateway_test.go

@@ -452,7 +452,7 @@ func TestValidateGateway(t *testing.T) {
 					},
 				}
 			},
-			wantErrors: []string{"Invalid value: \"1.2.3.4:8080\": spec.addresses[0].value in body must be of type ipv4"},
+			wantErrors: []string{"Invalid value: \"1.2.3.4:8080\": status.addresses[0].value in body must be of type ipv4"},
 		},
 		{
 			desc: "duplicate ip address or hostname",

hack/run-cel-validation-test.sh

@@ -35,15 +35,15 @@ cleanup() {
     return
   fi
 
-  rm config/webhook/kustomization.yaml
+  rm -f config/webhook/kustomization.yaml
 
   if [ "${KIND_CREATE_ATTEMPTED:-}" = true ]; then
     kind delete cluster --name "${CLUSTER_NAME}" || true
   fi
   CLEANED_UP=true
 }
 
-trap cleanup INT TERM
+trap cleanup INT TERM EXIT
 
 # For exit code
 res=0
@@ -53,7 +53,19 @@ res=0
 
 # Create cluster
 KIND_CREATE_ATTEMPTED=true
-kind create cluster --name "${CLUSTER_NAME}" || res=$?
+kind create cluster --name "${CLUSTER_NAME}"
+
+# Verify CEL validations before installing webhook.
+for CHANNEL in experimental standard; do
+  # Install CRDs.
+  kubectl apply -f "config/crd/${CHANNEL}/gateway*.yaml"
+
+  # Run tests.
+  go test -timeout=120s -count=1 sigs.k8s.io/gateway-api/hack/cel-validation
+
+  # Delete CRDs to reset environment.
+  kubectl delete -f "config/crd/${CHANNEL}/gateway*.yaml"
+done
 
 cat <<EOF >config/webhook/kustomization.yaml
 resources: