generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 588
Closed
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Description
What happened:
As HTTPRouteWeight test is Failing in nginx/nginx-gateway-fabric#3797.
What you expected to happen:
HTTPRouteWeight test pass.
How to reproduce it (as minimally and precisely as possible):
https://github.com/nginx/nginx-gateway-fabric/actions/runs/17256977734/job/48971158299
Anything else we need to know?:
As http.Response.StatusCode
is Deprecated in #4010 and although there is a workaround at
gateway-api/conformance/utils/http/http.go
Lines 144 to 147 in d28cd59
// if the deprecated field StatusCode is set, append it to StatusCodes for backwards compatibility | |
if expected.Response.StatusCode != 0 { | |
expected.Response.StatusCodes = append(expected.Response.StatusCodes, expected.Response.StatusCode) | |
} |
But in HTTPRouteWeight Test we call http.CompareRoundTrip()
directlly
gateway-api/conformance/tests/httproute-weight.go
Lines 112 to 114 in d28cd59
if err := http.CompareRoundTrip(t, &req, cReq, cRes, expected); err != nil { | |
return fmt.Errorf("response expectation failed for request: %w", err) | |
} |
Metadata
Metadata
Assignees
Labels
kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.