-
Notifications
You must be signed in to change notification settings - Fork 600
Description
What happened:
Discovered an issue with applyconfiguration generation via applyconfiguration-gen. Issue is around v1alpha3.TLSRoute which could be due to cross-version references to v1alpha2 types. Cross version reference for TLSRouteStatus and TLSRouteRule are present in below files
https://github.com/kubernetes-sigs/gateway-api/blob/main/apis/v1alpha3/tlsroute_types.go#L49
https://github.com/kubernetes-sigs/gateway-api/blob/main/apis/v1alpha3/tlsroute_types.go#L103,
The files applyconfiguration/apis/v1alpha3/tlsrouterule.go
and applyconfiguration/apis/v1alpha3/tlsroutestatus.go
do not get regenerated after a cleanup of /applyconfiguration dir
What you expected to happen:
The mentioned files should be re-generated via applyconfiguration-gen in the applyconfiguration/ dir (executed via make generate
) after a cleanup of the applyconfiguration/ dir
How to reproduce it (as minimally and precisely as possible):
- Ensure that
applyconfiguration/apis/v1alpha3/tlsrouterule.go
andapplyconfiguration/apis/v1alpha3/tlsroutestatus.go
files are present - rm -rf applyconfiguration/*
- make generate
- Observe that the 2 mentioned files are not regenerated
Anything else we need to know?: