Make non-implemented on windows an info

julianKatz · cemakd · commit 042176ae273b · 2025-08-01T17:37:52.000Z
diff --git a/pkg/linkcache/devices_windows.go b/pkg/linkcache/devices_windows.go
@@ -4,14 +4,13 @@ package linkcache
 
 import (
 	"context"
-	"fmt"
 	"time"
 
 	"k8s.io/klog/v2"
 )
 
 func NewDeviceCacheForNode(ctx context.Context, period time.Duration, nodeName string) (*DeviceCache, error) {
-	klog.Warningf("NewDeviceCacheForNode is not implemented for Windows")
+	klog.Infof("NewDeviceCacheForNode is not implemented for Windows")
 	return nil, nil
 }
 
@@ -20,7 +19,8 @@ func (d *DeviceCache) Run(ctx context.Context) {
 }
 
 func (d *DeviceCache) AddVolume(volumeID string) error {
-	return fmt.Errorf("AddVolume is not implemented for Windows")
+	klog.Infof("AddVolume is not implemented for Windows")
+	return nil
 }
 
 func (d *DeviceCache) RemoveVolume(volumeID string) {

Original file line number	Diff line number	Diff line change
`@@ -4,14 +4,13 @@ package linkcache`
`4`	`4`
`5`	`5`	`import (`
`6`	`6`	`"context"`
`7`		`- "fmt"`
`8`	`7`	`"time"`
`9`	`8`
`10`	`9`	`"k8s.io/klog/v2"`
`11`	`10`	`)`
`12`	`11`
`13`	`12`	`func NewDeviceCacheForNode(ctx context.Context, period time.Duration, nodeName string) (*DeviceCache, error) {`
`14`		`- klog.Warningf("NewDeviceCacheForNode is not implemented for Windows")`
	`13`	`+ klog.Infof("NewDeviceCacheForNode is not implemented for Windows")`
`15`	`14`	`return nil, nil`
`16`	`15`	`}`
`17`	`16`
`@@ -20,7 +19,8 @@ func (d *DeviceCache) Run(ctx context.Context) {`
`20`	`19`	`}`
`21`	`20`
`22`	`21`	`func (d *DeviceCache) AddVolume(volumeID string) error {`
`23`		`- return fmt.Errorf("AddVolume is not implemented for Windows")`
	`22`	`+ klog.Infof("AddVolume is not implemented for Windows")`
	`23`	`+ return nil`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`func (d *DeviceCache) RemoveVolume(volumeID string) {`