Skip to content

Commit 4e371e0

Browse files
authored
Merge pull request #154 from msau42/simplify-specs
Remove hardcoded environment variables from spec
2 parents c419540 + ac25e21 commit 4e371e0

File tree

2 files changed

+7
-20
lines changed

2 files changed

+7
-20
lines changed

deploy/kubernetes/base/controller.yaml

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -13,39 +13,31 @@ spec:
1313
labels:
1414
app: gcp-compute-persistent-disk-csi-driver
1515
spec:
16-
serviceAccount: csi-controller-sa
16+
serviceAccountName: csi-controller-sa
1717
containers:
1818
- name: csi-provisioner
1919
image: gcr.io/gke-release/csi-provisioner:v0.4.1-gke.0
2020
args:
2121
- "--v=5"
2222
- "--provisioner=com.google.csi.gcepd"
23-
- "--csi-address=$(ADDRESS)"
24-
env:
25-
- name: ADDRESS
26-
value: /csi/csi.sock
23+
- "--csi-address=/csi/csi.sock"
2724
volumeMounts:
2825
- name: socket-dir
2926
mountPath: /csi
3027
- name: csi-attacher
3128
image: gcr.io/gke-release/csi-attacher:v0.4.1-gke.0
3229
args:
3330
- "--v=5"
34-
- "--csi-address=$(ADDRESS)"
35-
env:
36-
- name: ADDRESS
37-
value: /csi/csi.sock
31+
- "--csi-address=/csi/csi.sock"
3832
volumeMounts:
3933
- name: socket-dir
4034
mountPath: /csi
4135
- name: gce-pd-driver
4236
image: gcr.io/gke-release/gcp-compute-persistent-disk-csi-driver:v0.2.0-gke.0
4337
args:
4438
- "--v=5"
45-
- "--endpoint=$(CSI_ENDPOINT)"
39+
- "--endpoint=unix:/csi/csi.sock"
4640
env:
47-
- name: CSI_ENDPOINT
48-
value: unix:/csi/csi.sock
4941
- name: GOOGLE_APPLICATION_CREDENTIALS
5042
value: "/etc/cloud-sa/cloud-sa.json"
5143
volumeMounts:

deploy/kubernetes/base/node.yaml

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,19 @@ spec:
1212
labels:
1313
app: gcp-compute-persistent-disk-csi-driver
1414
spec:
15-
serviceAccount: csi-node-sa
15+
serviceAccountName: csi-node-sa
1616
containers:
1717
- name: csi-driver-registrar
1818
image: gcr.io/gke-release/csi-driver-registrar:v0.4.1-gke.0
1919
args:
2020
- "--v=5"
21-
- "--csi-address=$(ADDRESS)"
21+
- "--csi-address=/var/lib/kubelet/plugins/com.google.csi.gcepd/csi.sock"
2222
- "--kubelet-registration-path=/var/lib/kubelet/plugins/com.google.csi.gcepd/csi.sock"
2323
lifecycle:
2424
preStop:
2525
exec:
2626
command: ["/bin/sh", "-c", "rm -rf /registration/com.google.csi.gcepd /registration/com.google.csi.gcepd-reg.sock"]
2727
env:
28-
- name: ADDRESS
29-
value: /var/lib/kubelet/plugins/com.google.csi.gcepd/csi.sock
3028
- name: KUBE_NODE_NAME
3129
valueFrom:
3230
fieldRef:
@@ -42,10 +40,7 @@ spec:
4240
image: gcr.io/gke-release/gcp-compute-persistent-disk-csi-driver:v0.2.0-gke.0
4341
args:
4442
- "--v=5"
45-
- "--endpoint=$(CSI_ENDPOINT)"
46-
env:
47-
- name: CSI_ENDPOINT
48-
value: unix:/csi/csi.sock
43+
- "--endpoint=unix:/csi/csi.sock"
4944
volumeMounts:
5045
- name: kubelet-dir
5146
mountPath: /var/lib/kubelet

0 commit comments

Comments
 (0)