File tree Expand file tree Collapse file tree 2 files changed +10
-4
lines changed Expand file tree Collapse file tree 2 files changed +10
-4
lines changed Original file line number Diff line number Diff line change @@ -573,6 +573,7 @@ func isCachingSetup(mainLvName string) (error, bool) {
573
573
return nil , false
574
574
}
575
575
576
+ // cacheSize is always in GiB
576
577
func fetchChunkSizeKiB (cacheSize string ) (string , error ) {
577
578
var chunkSize float64
578
579
Original file line number Diff line number Diff line change @@ -13,24 +13,29 @@ func TestFetchChunkSizeKiB(t *testing.T) {
13
13
}{
14
14
{
15
15
name : "chunk size is in the allowed range" ,
16
- cacheSize : "500 " ,
16
+ cacheSize : "500GiB " ,
17
17
expChunkSize : "512KiB" , //range defined in fetchChunkSizeKiB
18
18
},
19
19
{
20
20
name : "chunk size is set to the range ceil" ,
21
- cacheSize : "30000000 " ,
21
+ cacheSize : "30000000GiB " ,
22
22
expChunkSize : "1048576KiB" , //range defined in fetchChunkSizeKiB - max 1GiB
23
23
},
24
24
{
25
25
name : "chunk size is set to the allowed range floor" ,
26
- cacheSize : "100 " ,
26
+ cacheSize : "100GiB " ,
27
27
expChunkSize : "160KiB" , //range defined in fetchChunkSizeKiB - min 160 KiB
28
28
},
29
29
{
30
30
name : "cacheSize set to KiB also sets the chunk size to range floor" ,
31
- cacheSize : "1 " ,
31
+ cacheSize : "1GiB " ,
32
32
expChunkSize : "160KiB" , //range defined in fetchChunkSizeKiB - min 160 KiB
33
33
},
34
+ {
35
+ name : "chunk size with GiB string parses correctly" ,
36
+ cacheSize : "375GiB" ,
37
+ expChunkSize : "384KiB" ,
38
+ },
34
39
{
35
40
name : "invalid cacheSize" ,
36
41
cacheSize : "fdfsdKi" ,
You can’t perform that action at this time.
0 commit comments