Skip to content

Commit 648f174

Browse files
committed
Add unit test to fetchChucnkSizeKiB
Update existing unit test to have suffix GiB Add comment to clarify cache size is always in GiB
1 parent f54d16b commit 648f174

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

pkg/gce-pd-csi-driver/cache.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -573,6 +573,7 @@ func isCachingSetup(mainLvName string) (error, bool) {
573573
return nil, false
574574
}
575575

576+
// cacheSize is always in GiB
576577
func fetchChunkSizeKiB(cacheSize string) (string, error) {
577578
var chunkSize float64
578579

pkg/gce-pd-csi-driver/cache_test.go

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,24 +13,29 @@ func TestFetchChunkSizeKiB(t *testing.T) {
1313
}{
1414
{
1515
name: "chunk size is in the allowed range",
16-
cacheSize: "500",
16+
cacheSize: "500GiB",
1717
expChunkSize: "512KiB", //range defined in fetchChunkSizeKiB
1818
},
1919
{
2020
name: "chunk size is set to the range ceil",
21-
cacheSize: "30000000",
21+
cacheSize: "30000000GiB",
2222
expChunkSize: "1048576KiB", //range defined in fetchChunkSizeKiB - max 1GiB
2323
},
2424
{
2525
name: "chunk size is set to the allowed range floor",
26-
cacheSize: "100",
26+
cacheSize: "100GiB",
2727
expChunkSize: "160KiB", //range defined in fetchChunkSizeKiB - min 160 KiB
2828
},
2929
{
3030
name: "cacheSize set to KiB also sets the chunk size to range floor",
31-
cacheSize: "1",
31+
cacheSize: "1GiB",
3232
expChunkSize: "160KiB", //range defined in fetchChunkSizeKiB - min 160 KiB
3333
},
34+
{
35+
name: "chunk size with GiB string parses correctly",
36+
cacheSize: "375GiB",
37+
expChunkSize: "384KiB",
38+
},
3439
{
3540
name: "invalid cacheSize",
3641
cacheSize: "fdfsdKi",

0 commit comments

Comments
 (0)