Skip to content

Commit 6658ba9

Browse files
authored
Merge pull request #765 from TeweiLuo/windows-kubetest2
Fix windows param for kubetest2.
2 parents 1f6315d + 8624627 commit 6658ba9

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

test/k8s-integration/main.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -621,7 +621,6 @@ func runTestsWithConfig(testParams *testParameters, testConfigArg, reportPrefix
621621
os.Setenv("KUBECONFIG", kubeconfig)
622622

623623
artifactsDir, ok := os.LookupEnv("ARTIFACTS")
624-
reportArg := ""
625624
kubetestDumpDir := ""
626625
if ok {
627626
if len(reportPrefix) > 0 {
@@ -634,13 +633,14 @@ func runTestsWithConfig(testParams *testParameters, testConfigArg, reportPrefix
634633
}
635634
}
636635
ginkgoArgs := fmt.Sprintf("--ginkgo.focus=%s --ginkgo.skip=%s", testParams.testFocus, testParams.testSkip)
636+
637+
windowsArgs := ""
637638
if testParams.platform == "windows" {
638-
ginkgoArgs = ginkgoArgs + fmt.Sprintf(" --node-os-distro=%s --allowed-not-ready-nodes=%d", testParams.platform, testParams.allowedNotReadyNodes)
639+
windowsArgs = fmt.Sprintf(" --node-os-distro=%s --allowed-not-ready-nodes=%d", testParams.platform, testParams.allowedNotReadyNodes)
639640
}
640-
testArgs := fmt.Sprintf("%s %s %s",
641-
ginkgoArgs,
642-
testConfigArg,
643-
reportArg)
641+
ginkgoArgs = ginkgoArgs + windowsArgs
642+
643+
testArgs := fmt.Sprintf("%s %s", ginkgoArgs, testConfigArg)
644644

645645
kubeTestArgs := []string{
646646
"--test",
@@ -665,7 +665,7 @@ func runTestsWithConfig(testParams *testParameters, testConfigArg, reportPrefix
665665
kubeTest2Args = append(kubeTest2Args, fmt.Sprintf("--skip-regex=%s", testParams.testSkip))
666666
// kubetest uses 25 as default value for ginkgo parallelism (--nodes).
667667
kubeTest2Args = append(kubeTest2Args, "--parallel=25")
668-
kubeTest2Args = append(kubeTest2Args, fmt.Sprintf("--test-args=%s %s", testConfigArg, reportArg))
668+
kubeTest2Args = append(kubeTest2Args, fmt.Sprintf("--test-args=%s %s", testConfigArg, windowsArgs))
669669

670670
if kubetestDumpDir != "" {
671671
kubeTestArgs = append(kubeTestArgs, fmt.Sprintf("--dump=%s", kubetestDumpDir))

0 commit comments

Comments
 (0)