Skip to content

Commit 787e817

Browse files
committed
added data cache flags to test context and updated nvme disk list logic
1 parent 73de994 commit 787e817

File tree

2 files changed

+17
-8
lines changed

2 files changed

+17
-8
lines changed

pkg/gce-pd-csi-driver/cache.go

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -301,19 +301,27 @@ func RaidLocalSsds() error {
301301
klog.V(2).Infof("============================== Local SSDs are already RAIDed ==============================")
302302
return nil
303303
}
304-
info, err := common.RunCommand("grep" /* pipedCmd */, "DevicePath" /* pipeCmdArg */, "nvme", []string{"list", "-o", "json"}...)
304+
info, err := common.RunCommand("" /* pipedCmd */, "" /* pipeCmdArg */, "nvme", []string{"list", "-o", "json"}...)
305305
if err != nil {
306306
return fmt.Errorf("errored while scanning available NVME disks info: %v; err:%v", info, err)
307307
}
308-
infoString := strings.ReplaceAll(string(info), "\"", "")
309-
infoString = strings.TrimSpace(strings.ReplaceAll(infoString, ",", " "))
310-
infoSlice := strings.Split(infoString, "\n")
311-
klog.V(2).Infof("============================== NVME list %v ==============================", infoSlice)
308+
infoString := strings.TrimSpace(strings.ReplaceAll(string(info), "\n", " "))
309+
klog.V(2).Infof("============================== NVME list %v ==============================", infoString)
310+
infoString = strings.ReplaceAll(infoString, "\"", "")
311+
infoString = strings.ReplaceAll(infoString, " :", ":")
312+
infoString = strings.ReplaceAll(infoString, ": ", ":")
313+
infoString = strings.ReplaceAll(infoString, ",", " ")
314+
infoSlice := strings.Split(infoString, " ")
315+
312316
diskList := []string{}
313317
for _, diskInfo := range infoSlice {
314318
diskName := strings.TrimSpace(diskInfo)
315-
diskName = strings.TrimSpace(strings.Split(diskName, ":")[1])
316-
diskList = append(diskList, diskName)
319+
320+
if strings.Contains(diskName, "DevicePath") {
321+
diskName := strings.TrimSpace(strings.Split(diskName, ":")[1])
322+
323+
diskList = append(diskList, diskName)
324+
}
317325
}
318326
nvmeDiskCount := len(diskList)
319327
nvmeDiskList := strings.Join(diskList, " ")

test/e2e/utils/utils.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ func GCEClientAndDriverSetup(instance *remote.InstanceInfo, computeEndpoint stri
6060
"--multi-zone-volume-handle-disk-types=pd-standard",
6161
"--use-instance-api-to-poll-attachment-disk-types=pd-ssd",
6262
"--use-instance-api-to-list-volumes-published-nodes",
63-
"--enable-data-cache",
63+
"--enable-controller-data-cache",
64+
"--enable-node-data-cache",
6465
}
6566
extra_flags = append(extra_flags, fmt.Sprintf("--compute-endpoint=%s", computeEndpoint))
6667

0 commit comments

Comments
 (0)