address comments

Author: msau42

deploy/kubernetes/base/controller.yaml

@@ -51,4 +51,5 @@ spec:
         - name: cloud-sa-volume
           secret:
             secretName: cloud-sa
+  # This is needed due to https://github.com/kubernetes-sigs/kustomize/issues/504
   volumeClaimTemplates: []

deploy/kubernetes/overlays/dev/kustomization.yaml

@@ -8,15 +8,15 @@ patches:
 - node_always_pull.yaml
 images:
 - name: REPLACEME/gcp-compute-persistent-disk-csi-driver
-  # Replace this with your private image name
+  # Replace this with your private image names and tags
   newName: gcr.io/gke-release/gcp-compute-persistent-disk-csi-driver
   newTag: "v0.4.0-gke.0"
 - name: REPLACEME/csi-provisioner
-  newName: quay.io/k8scsi/csi-provisioner
-  newTag: "v1.0.1"
+  newName: gcr.io/gke-release/csi-provisioner
+  newTag: "v1.0.1-gke.0"
 - name: REPLACEME/csi-attacher
-  newName: quay.io/k8scsi/csi-attacher
-  newTag: "v1.0.1"
+  newName: gcr.io/gke-release/csi-attacher
+  newTag: "v1.0.1-gke.0"
 - name: REPLACEME/csi-node-driver-registrar
-  newName: quay.io/k8scsi/csi-node-driver-registrar
-  newTag: "v1.0.1"
+  newName: gcr.io/gke-release/csi-node-driver-registrar
+  newTag: "v1.0.1-gke.0"

deploy/kubernetes/overlays/prow-pull/README.md

@@ -0,0 +1 @@
+These overlays are intended to be only used by prow for CI testing.

deploy/kubernetes/overlays/prow-pull/kustomization.yaml

@@ -0,0 +1,17 @@
+apiVersion: kustomize.config.k8s.io/v1beta1
+kind: Kustomization
+bases:
+- ../../base
+images:
+- name: REPLACEME/gcp-compute-persistent-disk-csi-driver
+  newName: gcr.io/gke-release/gcp-compute-persistent-disk-csi-driver
+  newTag: "v0.4.0-gke.0"
+- name: REPLACEME/csi-provisioner
+  newName: quay.io/k8scsi/csi-provisioner
+  newTag: "v1.0.1"
+- name: REPLACEME/csi-attacher
+  newName: quay.io/k8scsi/csi-attacher
+  newTag: "v1.0.1"
+- name: REPLACEME/csi-node-driver-registrar
+  newName: quay.io/k8scsi/csi-node-driver-registrar
+  newTag: "v1.0.1"

test/run-k8s-integration.sh

@@ -10,7 +10,7 @@ set -o nounset
 set -o errexit
 
 readonly PKGDIR=${GOPATH}/src/sigs.k8s.io/gcp-compute-persistent-disk-csi-driver
-readonly overlay_name="${GCE_PD_OVERLAY_NAME:-dev}"
+readonly overlay_name="${GCE_PD_OVERLAY_NAME:-prow-pull}"
 readonly boskos_resource_type="${GCE_PD_BOSKOS_RESOURCE_TYPE:-gce-project}"
 readonly do_driver_build="${GCE_PD_DO_DRIVER_BUILD:-true}"
 export GCE_PD_VERBOSITY=9