Skip to content

Commit c9eb93f

Browse files
committed
Update version for alpha/devel images
Change-Id: I98a3c8fb5c188b1a1463ae86ae7f0ba62fdb2c4e
1 parent bc0afd8 commit c9eb93f

File tree

2 files changed

+19
-10
lines changed

2 files changed

+19
-10
lines changed

test/k8s-integration/version.go

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,11 @@ import (
1212

1313
var (
1414
versionNum = `(0|[1-9][0-9]*)`
15-
internalPatchVersion = `(\-[a-zA-Z0-9_.+-]+)`
15+
internalPatchVersion = `(\-gke\.[0-9]+)`
1616

1717
versionRegex = regexp.MustCompile(`^` + versionNum + `\.` + versionNum + `\.` + versionNum + internalPatchVersion + "?$")
1818
minorVersionRegex = regexp.MustCompile(`^` + versionNum + `\.` + versionNum + `$`)
19+
alphaVersionRegex = regexp.MustCompile(`^` + versionNum + `\.` + versionNum + `\.` + versionNum + `-alpha.*`)
1920
gkeExtraVersionRegex = regexp.MustCompile(`^(?:gke)\.(0|[1-9][0-9]*)$`)
2021
)
2122

@@ -24,7 +25,9 @@ type version struct {
2425
}
2526

2627
func (v *version) String() string {
27-
if v.version[3] != -1 {
28+
if v.version[3] == -2 {
29+
return fmt.Sprintf("%d.%d.%d-alpha", v.version[0], v.version[1], v.version[2])
30+
} else if v.version[3] != -1 {
2831
return fmt.Sprintf("%d.%d.%d-gke.%d", v.version[0], v.version[1], v.version[2], v.version[3])
2932
}
3033

@@ -82,6 +85,10 @@ func parseVersion(vs string) (*version, error) {
8285
case versionRegex.MatchString(vs):
8386
submatches = versionRegex.FindStringSubmatch(vs)
8487
lastIndex = 4
88+
case alphaVersionRegex.MatchString(vs):
89+
submatches = alphaVersionRegex.FindStringSubmatch(vs)
90+
v.version[3] = -2
91+
lastIndex = 4
8592
case minorVersionRegex.MatchString(vs):
8693
submatches = minorVersionRegex.FindStringSubmatch(vs)
8794
v.version[2] = -1
@@ -99,7 +106,7 @@ func parseVersion(vs string) (*version, error) {
99106
}
100107
}
101108

102-
if minorVersionRegex.MatchString(vs) {
109+
if minorVersionRegex.MatchString(vs) || alphaVersionRegex.MatchString(vs) {
103110
return &v, nil
104111
}
105112

test/k8s-integration/version_test.go

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,12 @@ func TestParseVersion(t *testing.T) {
7272
version: [4]int{1, 20, -1, -1},
7373
},
7474
},
75+
{
76+
version: "v1.26.0-alpha.0.293+6e3d62ca1c9e11",
77+
expectedV: version{
78+
version: [4]int{1, 26, 0, -2},
79+
},
80+
},
7581
// Negative test cases
7682
{
7783
version: "1",
@@ -106,11 +112,11 @@ func TestParseVersion(t *testing.T) {
106112
expectErr: true,
107113
},
108114
{
109-
version: "1.18.0-alpha.x",
115+
version: "1.18.0-beta.x",
110116
expectErr: true,
111117
},
112118
{
113-
version: "1.18.0-alpha.beta.1",
119+
version: "1.18.0-beta.alpha.1",
114120
expectErr: true,
115121
},
116122
{
@@ -121,10 +127,6 @@ func TestParseVersion(t *testing.T) {
121127
version: "1.18-alpha.3.673+73326ef01d2d7c",
122128
expectErr: true,
123129
},
124-
{
125-
version: "1.18.3-alpha.3.673+73326ef01d2d7c",
126-
expectErr: true,
127-
},
128130
}
129131

130132
for i, tc := range tests {
@@ -138,7 +140,7 @@ func TestParseVersion(t *testing.T) {
138140
}
139141

140142
if err == nil && tc.expectErr {
141-
t.Fatal("Got no error but expected one")
143+
t.Fatalf("Got no error but expected one with version %s", tc.version)
142144
return
143145
}
144146

0 commit comments

Comments
 (0)