Skip to content

Commit caf5514

Browse files
committed
Update parallel setting for Windows in integration test
Current parallel setting to 25 is too high especially for Windows. Every node will have about 8-10 disks are being attached and fomatted around the same time. For Windows Disk format time could reach about 4 mins which makes the whole pod start time exceeds 5 mins and timeout. Add parallel parameter into test. By default it sets to 10 to any platform. If it does not work well for Windows, we can adjust in the test script by passing parallel parameter.
1 parent 14f73de commit caf5514

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

test/k8s-integration/main.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ var (
7070
testFocus = flag.String("test-focus", "", "test focus for Kubernetes e2e")
7171

7272
useKubeTest2 = flag.Bool("use-kubetest2", false, "use kubetest2 to run e2e tests")
73+
parallel = flag.Int("parallel", 10, "the number of parallel tests setting for ginkgo parallelism")
7374
)
7475

7576
const (
@@ -99,6 +100,7 @@ type testParameters struct {
99100
clusterVersion string
100101
nodeVersion string
101102
imageType string
103+
parallel int
102104
}
103105

104106
func init() {
@@ -200,6 +202,7 @@ func handle() error {
200202
deploymentStrategy: *deploymentStrat,
201203
useGKEManagedDriver: *useGKEManagedDriver,
202204
imageType: *imageType,
205+
parallel: *parallel,
203206
}
204207

205208
goPath, ok := os.LookupEnv("GOPATH")
@@ -663,8 +666,7 @@ func runTestsWithConfig(testParams *testParameters, testConfigArg, reportPrefix
663666
}
664667
kubeTest2Args = append(kubeTest2Args, fmt.Sprintf("--focus-regex=%s", testParams.testFocus))
665668
kubeTest2Args = append(kubeTest2Args, fmt.Sprintf("--skip-regex=%s", testParams.testSkip))
666-
// kubetest uses 25 as default value for ginkgo parallelism (--nodes).
667-
kubeTest2Args = append(kubeTest2Args, "--parallel=25")
669+
kubeTest2Args = append(kubeTest2Args, fmt.Sprintf("--parallel=%d", testParams.parallel))
668670
kubeTest2Args = append(kubeTest2Args, fmt.Sprintf("--test-args=%s %s", testConfigArg, windowsArgs))
669671

670672
if kubetestDumpDir != "" {

0 commit comments

Comments
 (0)