Update the default cache unit to GiB from MiB

Author: Sneha-at

cmd/gce-pd-csi-driver/main.go

@@ -242,10 +242,10 @@ func handle() {
 
 	if *enableNodeDataCacheFlag {
 		if nodeName == nil || *nodeName == "" {
-			klog.Fatalf("Data cache enabled, but --node-name not passed")
+			klog.Errorf("Data cache enabled, but --node-name not passed")
 		}
 		if err := setupDataCache(ctx, *nodeName); err != nil {
-			klog.Fatalf("DataCache setup failed: %v", err)
+			klog.Errorf("DataCache setup failed: %v", err)
 		}
 	}
 

pkg/common/parameters.go

@@ -251,7 +251,7 @@ func ExtractAndDefaultParameters(parameters map[string]string, driverName string
 				return p, d, fmt.Errorf("parameters contain invalid dataCacheSize parameter: %w", err)
 			}
 			d.DataCacheSize = strconv.FormatInt(paramDataCacheSize, 10)
-			klog.V(2).Infof("====== Data cache size is %v ======", v)
+			klog.V(2).Infof("====== Data cache size is %v GiB ======", d.DataCacheSize)
 		case ParameterKeyDataCacheMode:
 			if !enableDataCache {
 				return p, d, fmt.Errorf("data caching enabled %v; parameters contains invalid option %q", enableDataCache, ParameterKeyDataCacheSize)
@@ -260,7 +260,7 @@ func ExtractAndDefaultParameters(parameters map[string]string, driverName string
 				return p, d, fmt.Errorf("parameters contains invalid option: %w", err)
 			}
 			d.DataCacheMode = v
-			klog.V(2).Infof("====== Data cache mode is %v ======", v)
+			klog.V(2).Infof("====== Data cache mode is %v ======", d.DataCacheMode)
 		case ParameterKeyResourceTags:
 			if err := extractResourceTagsParameter(v, p.ResourceTags); err != nil {
 				return p, d, err

pkg/gce-pd-csi-driver/cache.go

@@ -164,14 +164,15 @@ func setupCaching(devicePath string, req *csi.NodeStageVolumeRequest, nodeId str
 	} else {
 		fastCacheSize := req.GetPublishContext()[common.ContexLocalSsdCacheSize]
 		chunkSize := "960" // Cannot use default chunk size(64KiB) as it errors on maxChunksAllowed. Unit - KiB
-		klog.V(2).Infof("============================== fastCacheSize is %v ==============================", fastCacheSize)
+		klog.V(2).Infof("============================== fastCacheSize is %v GiB ==============================", fastCacheSize)
 		klog.V(2).Infof("============================== lvcreate fast cache layer again with the VolumeGroup %v==============================", volumeGroupName)
 		args = []string{
 			"--yes",
 			"-n",
 			cacheLvName,
 			"-L",
-			fastCacheSize,
+			// ConvertGiStringToInt64 converts the input size to GiB so default to "g" for cache size - LVM g|G is GiB.
+			fastCacheSize + "g",
 			volumeGroupName,
 			raidedLocalSsdPath,
 		}