Skip to content

Commit f883f58

Browse files
rcmadhankumarroot
authored andcommitted
Makefile and github workflow fixed
1 parent fe391d3 commit f883f58

File tree

3 files changed

+11
-37
lines changed

3 files changed

+11
-37
lines changed

.github/workflows/go.yml

Lines changed: 0 additions & 24 deletions
This file was deleted.

Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@
1515
FROM golang:1.17 AS builder
1616
WORKDIR /go/src/sigs.k8s.io/ibm-powervs-block-csi-driver
1717
ADD . .
18-
ARG TARGETPLATFORM
19-
RUN ARCH=$(echo $TARGETPLATFORM | cut -f2 -d '/') make driver
18+
RUN make driver
2019

2120
FROM k8s.gcr.io/build-image/debian-base:v2.1.3 AS debian-base
2221
RUN clean-install ca-certificates e2fsprogs mount udev util-linux xfsprogs bash multipath-tools sg3-utils

Makefile

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ PKG=sigs.k8s.io/ibm-powervs-block-csi-driver
1616
GIT_COMMIT?=$(shell git rev-parse --short HEAD)
1717
BUILD_DATE?=$(shell date -u +"%Y-%m-%dT%H:%M:%SZ")
1818
REGISTRY?=gcr.io/k8s-staging-cloud-provider-ibm
19-
IMAGE?=ibm-powervs-block-csi-driver
19+
IMG?=ibm-powervs-block-csi-driver
2020
TAG?=$(GIT_COMMIT)
2121
LDFLAGS?="-X ${PKG}/pkg/driver.driverVersion=${TAG} -X ${PKG}/pkg/driver.gitCommit=${GIT_COMMIT} -X ${PKG}/pkg/driver.buildDate=${BUILD_DATE} -s -w"
2222

@@ -32,41 +32,40 @@ bin:
3232
@mkdir -p $@
3333

3434
.PHONY: driver
35-
bin/ibm-powervs-block-csi-driver:
3635
driver: | bin
37-
CGO_ENABLED=0 GOOS=linux GOARCH=$(ARCH) go build -ldflags ${LDFLAGS} -o bin/ibm-powervs-block-csi-driver ./cmd/
36+
CGO_ENABLED=0 go build -ldflags ${LDFLAGS} -o bin/ibm-powervs-block-csi-driver ./cmd/
3837

3938
.PHONY: test
4039
test:
4140
go test -v -race ./cmd/... ./pkg/...
4241

4342
.PHONY: image
4443
image:
45-
docker build -t $(REGISTRY)/$(IMAGE):$(TAG) . --target debian-base
44+
docker build -t $(REGISTRY)/$(IMG):$(TAG) . --target debian-base
4645

4746
.PHONY: push
4847
push:
49-
docker push $(REGISTRY)/$(IMAGE):$(TAG)
48+
docker push $(REGISTRY)/$(IMG):$(TAG)
5049

5150
build-image-and-push-linux-amd64: init-buildx
5251
{ \
5352
set -e ; \
5453
docker buildx build \
55-
--build-arg TARGETPLATFORM=linux/amd64 \
56-
-t $(REGISTRY)/$(IMAGE):$(TAG)_linux_amd64 --push . --target debian-base; \
54+
--platform linux/amd64 \
55+
-t $(REGISTRY)/$(IMG):$(TAG)_linux_amd64 --push . --target debian-base; \
5756
}
5857

5958
build-image-and-push-linux-ppc64le: init-buildx
6059
{ \
6160
set -e ; \
6261
docker buildx build \
63-
--build-arg TARGETPLATFORM=linux/ppc64le \
64-
-t $(REGISTRY)/$(IMAGE):$(TAG)_linux_ppc64le --push . --target debian-base; \
62+
--platform linux/ppc64le \
63+
-t $(REGISTRY)/$(IMG):$(TAG)_linux_ppc64le --push . --target debian-base; \
6564
}
6665

6766
build-and-push-multi-arch: build-image-and-push-linux-amd64 build-image-and-push-linux-ppc64le
68-
docker manifest create --amend $(REGISTRY)/$(IMAGE):$(TAG) $(REGISTRY)/$(IMAGE):$(TAG)_linux_amd64 $(REGISTRY)/$(IMAGE):$(TAG)_linux_ppc64le
69-
docker manifest push -p $(REGISTRY)/$(IMAGE):$(TAG)
67+
docker manifest create --amend $(REGISTRY)/$(IMG):$(TAG) $(REGISTRY)/$(IMG):$(TAG)_linux_amd64 $(REGISTRY)/$(IMG):$(TAG)_linux_ppc64le
68+
docker manifest push -p $(REGISTRY)/$(IMG):$(TAG)
7069

7170
.PHONY: clean
7271
clean:

0 commit comments

Comments
 (0)