Skip to content

Commit f20ff9f

Browse files
authored
chart(jobset): add controller.hostNetwork toggle (#978)
* chart(jobset): add controller.hostNetwork toggle Signed-off-by: Mohammad Mamdouhi <m.mamdouhi@instadeep.com> * charts(jobset): document controller.hostNetwork and regen README Signed-off-by: Mohammad Mamdouhi <m.mamdouhi@instadeep.com> --------- Signed-off-by: Mohammad Mamdouhi <m.mamdouhi@instadeep.com>
1 parent 8772a1e commit f20ff9f

File tree

4 files changed

+44
-4
lines changed

4 files changed

+44
-4
lines changed

charts/jobset/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ See [helm uninstall](https://helm.sh/docs/helm/helm_uninstall) for command docum
8888
| controller.affinity | object | `{}` | Affinity of the jobset controller pods. |
8989
| controller.tolerations | list | `[]` | Tolerations of the jobset controller pods. |
9090
| controller.podSecurityContext | object | `{"runAsNonRoot":true,"seccompProfile":{"type":"RuntimeDefault"}}` | Security context of all jobset controller containers. |
91+
| controller.hostNetwork | bool | `false` | Run the controller/webhook Pods on the node’s network namespace instead of the overlay CNI. |
9192
| certManager.enable | bool | `false` | Whether to use cert-manager to generate certificates for the jobset webhook. |
9293
| certManager.issuerRef | object | `{}` | The reference to the issuer. If empty, self-signed issuer will be created and used. |
9394
| prometheus.enable | bool | `false` | Whether to enable Prometheus metrics exporting. |

charts/jobset/templates/controller/deployment.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,3 +137,7 @@ spec:
137137
{{- toYaml . | nindent 8 }}
138138
{{- end }}
139139
serviceAccountName: {{ include "jobset.controller.serviceAccount.name" . }}
140+
{{- if .Values.controller.hostNetwork }}
141+
hostNetwork: true
142+
dnsPolicy: ClusterFirstWithHostNet
143+
{{- end }}

charts/jobset/values.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,8 @@ controller:
7575
runAsNonRoot: true
7676
seccompProfile:
7777
type: RuntimeDefault
78+
# -- Run the controller/webhook Pods on the node’s network namespace instead of the overlay CNI.
79+
hostNetwork: false
7880
certManager:
7981
# -- Whether to use cert-manager to generate certificates for the jobset webhook.
8082
enable: false

site/content/en/docs/reference/jobset.v1alpha2.md

Lines changed: 37 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,40 @@ An empty list will apply to all replicatedJobs.</p>
246246
</tbody>
247247
</table>
248248

249+
## `IndividualJobStatus` {#jobset-x-k8s-io-v1alpha2-IndividualJobStatus}
250+
251+
252+
**Appears in:**
253+
254+
- [JobSetStatus](#jobset-x-k8s-io-v1alpha2-JobSetStatus)
255+
256+
257+
<p>IndividualJobStatus holds the status of an individual Job within a ReplicatedJob.</p>
258+
259+
260+
<table class="table">
261+
<thead><tr><th width="30%">Field</th><th>Description</th></tr></thead>
262+
<tbody>
263+
264+
265+
<tr><td><code>name</code> <B>[Required]</B><br/>
266+
<code>string</code>
267+
</td>
268+
<td>
269+
<p>Name of the Job.</p>
270+
</td>
271+
</tr>
272+
<tr><td><code>recreates</code> <B>[Required]</B><br/>
273+
<code>int32</code>
274+
</td>
275+
<td>
276+
<p>Recreates is the number of times an individual Job has been recreated.
277+
This counter is reset to 0 if the parent ReplicatedJob or JobSet is restarted.</p>
278+
</td>
279+
</tr>
280+
</tbody>
281+
</table>
282+
249283
## `JobSetRestartStrategy` {#jobset-x-k8s-io-v1alpha2-JobSetRestartStrategy}
250284

251285
(Alias of `string`)
@@ -417,12 +451,11 @@ It can be either Completed or Failed. Otherwise, it is empty by default.</p>
417451
<p>ReplicatedJobsStatus track the number of JobsReady for each replicatedJob.</p>
418452
</td>
419453
</tr>
420-
<tr><td><code>individualJobRecreates</code><br/>
421-
<code>map[string]int32</code>
454+
<tr><td><code>individualJobsStatus</code><br/>
455+
<a href="#jobset-x-k8s-io-v1alpha2-IndividualJobStatus"><code>[]IndividualJobStatus</code></a>
422456
</td>
423457
<td>
424-
<p>IndividualJobRecreates tracks the number of times an individual Job within
425-
the JobSet has been recreated (i.e. in case of RecreateJob failure policy).</p>
458+
<p>IndividualJobsStatus tracks the status of individual Jobs within ReplicatedJobs.</p>
426459
</td>
427460
</tr>
428461
</tbody>

0 commit comments

Comments
 (0)