Merge pull request #190 from pfeifferj/feat/pre-commit-hooks

Feat: Add pre commit hooks

Author: pfeifferj

.github/ISSUE_TEMPLATE/feature.yaml

@@ -13,4 +13,3 @@ body:
       * Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue to help the community and maintainers prioritize this request
       * Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
       * If you are interested in working on this issue or have submitted a pull request, please leave a comment
-      

.github/workflows/cleanup-nightly-builds.yaml

@@ -30,10 +30,10 @@ jobs:
             const retentionDays = parseInt('${{ github.event.inputs.retention_days || 7 }}');
             const dryRun = ${{ github.event.inputs.dry_run || false }};
             const packageName = 'karpenter-provider-ibm-cloud/controller';
-            
+
             console.log(`Retention period: ${retentionDays} days`);
             console.log(`Dry run: ${dryRun}`);
-            
+
             // Get all package versions
             let versions = [];
             try {
@@ -52,52 +52,52 @@ jobs:
               }
               throw error;
             }
-            
+
             const now = new Date();
             const cutoffDate = new Date(now.getTime() - (retentionDays * 24 * 60 * 60 * 1000));
-            
+
             console.log(`Cutoff date: ${cutoffDate.toISOString()}`);
             console.log(`Total versions found: ${versions.length}`);
-            
+
             const nightlyVersions = versions.filter(v => {
               // Check if this is a nightly build by examining tags
               const tags = v.metadata?.container?.tags || [];
-              return tags.some(tag => 
-                tag.includes('nightly') || 
+              return tags.some(tag =>
+                tag.includes('nightly') ||
                 tag.match(/v\d+\.\d+\.\d+-\d{4}-\d{2}-\d{2}-[a-f0-9]+-/)
               );
             });
-            
+
             console.log(`Nightly versions found: ${nightlyVersions.length}`);
-            
+
             const versionsToDelete = nightlyVersions.filter(v => {
               const createdAt = new Date(v.created_at);
               return createdAt < cutoffDate;
             });
-            
+
             console.log(`Versions to delete: ${versionsToDelete.length}`);
-            
+
             if (versionsToDelete.length === 0) {
               console.log('No old nightly builds to clean up');
               return;
             }
-            
+
             // Create summary
             let summary = '# Nightly Build Cleanup Summary\n\n';
             summary += `- **Retention Period**: ${retentionDays} days\n`;
             summary += `- **Cutoff Date**: ${cutoffDate.toISOString()}\n`;
             summary += `- **Total Nightly Versions**: ${nightlyVersions.length}\n`;
             summary += `- **Versions to Delete**: ${versionsToDelete.length}\n`;
             summary += `- **Dry Run**: ${dryRun}\n\n`;
-            
+
             summary += '## Versions to be deleted:\n\n';
             summary += '| Version | Created At | Tags |\n';
             summary += '|---------|------------|------|\n';
-            
+
             for (const version of versionsToDelete) {
               const tags = version.metadata?.container?.tags || [];
               summary += `| ${version.name} | ${version.created_at} | ${tags.join(', ')} |\n`;
-              
+
               if (!dryRun) {
                 try {
                   // First, try to get the version to confirm it exists
@@ -115,7 +115,7 @@ jobs:
                     }
                     throw getError;
                   }
-                  
+
                   // Version exists, proceed with deletion
                   await github.rest.packages.deletePackageVersionForUser({
                     package_type: 'container',
@@ -133,13 +133,13 @@ jobs:
                 }
               }
             }
-            
+
             // Write summary
             const fs = require('fs');
             fs.writeFileSync(process.env.GITHUB_STEP_SUMMARY, summary);
-            
+
             if (dryRun) {
               console.log('Dry run completed - no versions were actually deleted');
             } else {
               console.log('Cleanup completed');
-            }
+            }

.github/workflows/e2e-tests-in-cluster.yaml

@@ -13,41 +13,41 @@ on:
     - cron: '0 2 * * *'
   pull_request:
     types: [labeled]
-    
+
 jobs:
   e2e-tests:
     # Use self-hosted runner with 'ibm-e2e' label
     runs-on: [self-hosted, ibm-e2e]
     if: |
-      github.event_name == 'workflow_dispatch' || 
+      github.event_name == 'workflow_dispatch' ||
       github.event_name == 'schedule' ||
       (github.event_name == 'pull_request' && contains(github.event.label.name, 'run-e2e'))
-    
+
     # Prevent concurrent e2e runs
     concurrency:
       group: e2e-tests
       cancel-in-progress: false
-    
+
     timeout-minutes: 60
-    
+
     container:
       # Run in a container with necessary tools
       image: golang:1.24.4
       options: --user 0
-    
+
     steps:
     - name: Checkout
       uses: actions/checkout@v4
 
     - name: Install dependencies
       run: |
         apt-get update && apt-get install -y curl jq
-        
+
         # Install kubectl
         curl -LO "https://dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/bin/linux/amd64/kubectl"
         chmod +x kubectl
         mv kubectl /usr/local/bin/
-        
+
         # Install IBM Cloud CLI
         curl -fsSL https://clis.cloud.ibm.com/install/linux | sh
         ibmcloud plugin install vpc-infrastructure
@@ -56,11 +56,11 @@ jobs:
       env:
         KUBECONFIG_CONTENT: ${{ secrets.KUBECONFIG }}
       run: |
-        # Create kubeconfig from secret 
+        # Create kubeconfig from secret
         printf '%s' "$KUBECONFIG_CONTENT" | base64 -d > /tmp/kubeconfig
         chmod 600 /tmp/kubeconfig
         export KUBECONFIG=/tmp/kubeconfig
-        
+
         # Verify the kubeconfig works
         kubectl version --client
 
@@ -86,8 +86,8 @@ jobs:
       run: |
         # Install or update Karpenter CRDs
         kubectl apply -f charts/crds/
-        
-        # Restart operator pods to pull latest upstream image tag  
+
+        # Restart operator pods to pull latest upstream image tag
         kubectl rollout restart deployment/karpenter-karpenter-ibm -n karpenter
 
     - name: Run E2E tests
@@ -111,7 +111,7 @@ jobs:
       run: |
         # The in-cluster config will be automatically detected
         go test -v -timeout 45m ./test/e2e/... -run TestE2E
-        
+
         # Run benchmarks if requested
         if [[ "$RUN_E2E_BENCHMARKS" == "true" ]]; then
           go test -v -timeout 30m ./test/e2e/... -run=^$ -bench=.
@@ -123,7 +123,7 @@ jobs:
         KUBECONFIG: /tmp/kubeconfig
       run: |
         mkdir -p test-artifacts
-        
+
         # Collect logs and events
         kubectl logs -n karpenter -l app.kubernetes.io/name=karpenter --tail=1000 > test-artifacts/karpenter-logs.txt || true
         kubectl get events -A --sort-by='.lastTimestamp' > test-artifacts/events.txt || true
@@ -150,8 +150,8 @@ jobs:
         kubectl delete nodeclaims -l test=e2e --all --timeout=5m || true
         kubectl delete nodepools -l test=e2e --all --timeout=5m || true
         kubectl delete ibmnodeclasses -l test=e2e --all --timeout=5m || true
-        
+
         # Clean up IBM Cloud instances
         ibmcloud is instances --output json | \
           jq -r '.[] | select(.tags | index("karpenter-e2e")) | .id' | \
-          xargs -I {} ibmcloud is instance-delete {} --force || true
+          xargs -I {} ibmcloud is instance-delete {} --force || true

.github/workflows/helm-test.yaml

@@ -51,4 +51,3 @@ jobs:
 
         # Validate template rendering
         helm template . -f ci-values.yaml
-        

.github/workflows/nightly-build.yaml

@@ -55,23 +55,23 @@ jobs:
           # Get the latest tag
           LATEST_TAG=$(git describe --tags --abbrev=0 2>/dev/null || echo "v0.0.0")
           echo "Latest tag: $LATEST_TAG"
-          
+
           # Get commit info
           SHORT_SHA=$(git rev-parse --short HEAD)
           COMMIT_DATE=$(git show -s --format=%cs)
-          
+
           # Generate nightly version
           # Format: <latest-tag>-<date>-<short-sha>-<suffix>
           SUFFIX="${{ github.event.inputs.tag_suffix || 'nightly' }}"
           NIGHTLY_VERSION="${LATEST_TAG}-${COMMIT_DATE}-${SHORT_SHA}-${SUFFIX}"
-          
+
           echo "nightly_version=$NIGHTLY_VERSION" >> $GITHUB_OUTPUT
           echo "short_sha=$SHORT_SHA" >> $GITHUB_OUTPUT
           echo "commit_date=$COMMIT_DATE" >> $GITHUB_OUTPUT
-          
+
           # Also create a simple 'nightly' tag that always points to latest
           echo "latest_tag=nightly" >> $GITHUB_OUTPUT
-          
+
           echo "Generated nightly version: $NIGHTLY_VERSION"
 
       - name: Build and push multi-arch images
@@ -95,35 +95,35 @@ jobs:
           # Verify the manifests
           echo "Verifying nightly version manifest..."
           docker buildx imagetools inspect $KO_DOCKER_REPO:${{ steps.version.outputs.nightly_version }}
-          
+
           echo "Verifying latest nightly manifest..."
           docker buildx imagetools inspect $KO_DOCKER_REPO:${{ steps.version.outputs.latest_tag }}
 
       - name: Create build summary
         run: |
           cat >> $GITHUB_STEP_SUMMARY <<EOF
           # Nightly Build Summary
-          
+
           ## Version Information
           - **Nightly Version**: \`${{ steps.version.outputs.nightly_version }}\`
           - **Commit SHA**: \`${{ steps.version.outputs.short_sha }}\`
           - **Commit Date**: \`${{ steps.version.outputs.commit_date }}\`
-          
+
           ## Images Published
           - \`$KO_DOCKER_REPO:${{ steps.version.outputs.nightly_version }}\`
           - \`$KO_DOCKER_REPO:nightly\` (latest nightly)
-          
+
           ## Platforms
           - linux/amd64
           - linux/arm64
-          
+
           ## Usage
-          
+
           To use the latest nightly build:
           \`\`\`bash
           podman pull $KO_DOCKER_REPO:nightly
           \`\`\`
-          
+
           To use this specific nightly build:
           \`\`\`bash
           podman pull $KO_DOCKER_REPO:${{ steps.version.outputs.nightly_version }}
@@ -150,17 +150,17 @@ jobs:
           script: |
             const date = new Date().toISOString().split('T')[0];
             const title = `Nightly build failed - ${date}`;
-            
+
             // Check if issue already exists
             const issues = await github.rest.issues.listForRepo({
               owner: context.repo.owner,
               repo: context.repo.repo,
               labels: ['nightly-build-failure'],
               state: 'open'
             });
-            
+
             const existingIssue = issues.data.find(issue => issue.title === title);
-            
+
             if (!existingIssue) {
               await github.rest.issues.create({
                 owner: context.repo.owner,
@@ -169,4 +169,4 @@ jobs:
                 body: `The nightly build failed on ${date}.\n\nWorkflow run: ${context.serverUrl}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}`,
                 labels: ['nightly-build-failure', 'automated']
               });
-            }
+            }

.github/workflows/pages-deploy.yml

@@ -56,27 +56,27 @@ jobs:
       - name: Package Helm charts
         run: |
           mkdir -p _helm-repo
-          
+
           # Package the chart from charts/ directory
           if [ -f "charts/Chart.yaml" ]; then
             echo "Packaging chart: charts/"
             helm package charts/ --destination _helm-repo
           fi
-          
+
           # Generate index
           helm repo index _helm-repo --url https://karpenter-ibm.sh
 
       - name: Combine site content
         run: |
           # Put docs at root (since we build with root URL)
           cp -r site/* .
-          
+
           # Keep charts at root (existing customer configs)
           cp -r _helm-repo/* .
-          
+
           # Preserve custom domain configuration
           cp docs/CNAME .
-          
+
           # Clean up build directories
           rm -rf site _helm-repo