fix: truncate primary network attachment name to meet VPC 63-char limit

The primary network attachment name is constructed from the nodeclaim name
plus a suffix. IBM Cloud VPC has a 63-character limit for resource names.

Previously, long nodeclaim names (e.g., from long nodepool names) would
exceed this limit, causing instance creation to fail with validation errors.

Signed-off-by: Josephine Pfeiffer <[email protected]>

Author: pfeifferj

pkg/providers/vpc/instance/provider.go

@@ -362,8 +362,14 @@ func (p *VPCInstanceProvider) Create(ctx context.Context, nodeClaim *karpv1.Node
 	}
 
 	// Create primary network attachment with VNI
+	// VPC resource names have a max length of 63 characters
+	// The suffix "-primary" is 8 chars, leaving 55 chars for the nodeclaim name
+	attachmentName := nodeClaim.Name
+	if len(attachmentName) > 55 {
+		attachmentName = attachmentName[:55]
+	}
 	primaryNetworkAttachment := &vpcv1.InstanceNetworkAttachmentPrototype{
-		Name:                    &[]string{fmt.Sprintf("%s-primary-attachment", nodeClaim.Name)}[0],
+		Name:                    &[]string{fmt.Sprintf("%s-primary", attachmentName)}[0],
 		VirtualNetworkInterface: vniPrototype,
 	}