removing duplicate imageSpec from MIC

CreateOrPatch MIC API receives slice of imageSpecs. Since usually the
input is created by going over the the target nodes and adding their
images to the slice, we need to remove duplicate images, since for most
of the cases all the nodes will have the same target image

Author: yevgeny-shnaidman

internal/mic/mic.go

@@ -9,6 +9,7 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/types"
+	"k8s.io/apimachinery/pkg/util/sets"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
 	"sigs.k8s.io/controller-runtime/pkg/log"
@@ -50,6 +51,8 @@ func (mici *micImpl) CreateOrPatch(ctx context.Context, name, ns string, images
 		},
 	}
 
+	images = filterDuplicateImages(images)
+
 	opRes, err := controllerutil.CreateOrPatch(ctx, mici.client, mic, func() error {
 
 		mic.Spec = kmmv1beta1.ModuleImagesConfigSpec{
@@ -127,3 +130,15 @@ func (mici *micImpl) DoAllImagesExist(micObj *kmmv1beta1.ModuleImagesConfig) boo
 
 	return true
 }
+
+func filterDuplicateImages(images []kmmv1beta1.ModuleImageSpec) []kmmv1beta1.ModuleImageSpec {
+	imagesSet := sets.New[string]()
+	filteredImages := make([]kmmv1beta1.ModuleImageSpec, 0, len(images))
+	for _, image := range images {
+		if !imagesSet.Has(image.Image) {
+			imagesSet.Insert(image.Image)
+			filteredImages = append(filteredImages, image)
+		}
+	}
+	return filteredImages
+}

internal/mic/mic_test.go

@@ -368,3 +368,26 @@ var _ = Describe("DoAllImagesExist", func() {
 		Expect(micAPI.DoAllImagesExist(micObj)).To(BeTrue())
 	})
 })
+
+var _ = Describe("filterDuplicateImages", func() {
+	It("check flow", func() {
+		images := []kmmv1beta1.ModuleImageSpec{
+			{Image: "example.registry.com/org/user/image1:tag"},
+			{Image: "example.registry.com/org/user/image2:tag"},
+			{Image: "example.registry.com/org/user/image3:tag"},
+			{Image: "example.registry.com/org/user/image2:tag"},
+			{Image: "example.registry.com/org/user/image4:tag"},
+			{Image: "example.registry.com/org/user/image1:tag"},
+		}
+
+		expectedRes := []kmmv1beta1.ModuleImageSpec{
+			{Image: "example.registry.com/org/user/image1:tag"},
+			{Image: "example.registry.com/org/user/image2:tag"},
+			{Image: "example.registry.com/org/user/image3:tag"},
+			{Image: "example.registry.com/org/user/image4:tag"},
+		}
+
+		res := filterDuplicateImages(images)
+		Expect(res).To(Equal(expectedRes))
+	})
+})