Adding GetImageStatus API to mbsc package

This API return the status of the an image in the MBSC object based on
the image and the action. Is required by the MBSC controller

Author: yevgeny-shnaidman

internal/mbsc/mbsc.go

@@ -21,6 +21,7 @@ type MBSC interface {
 		moduleImageSpec *kmmv1beta1.ModuleImageSpec, action kmmv1beta1.BuildOrSignAction) error
 	GetImageSpec(mbscObj *kmmv1beta1.ModuleBuildSignConfig, image string) *kmmv1beta1.ModuleBuildSignSpec
 	SetImageStatus(mbscObj *kmmv1beta1.ModuleBuildSignConfig, image string, action kmmv1beta1.BuildOrSignAction, status kmmv1beta1.BuildOrSignStatus)
+	GetImageStatus(mbscObj *kmmv1beta1.ModuleBuildSignConfig, image string, action kmmv1beta1.BuildOrSignAction) kmmv1beta1.BuildOrSignStatus
 }
 
 type mbsc struct {
@@ -85,6 +86,15 @@ func (m *mbsc) SetImageStatus(mbscObj *kmmv1beta1.ModuleBuildSignConfig, image s
 	mbscObj.Status.Images = append(mbscObj.Status.Images, imageState)
 }
 
+func (m *mbsc) GetImageStatus(mbscObj *kmmv1beta1.ModuleBuildSignConfig, image string, action kmmv1beta1.BuildOrSignAction) kmmv1beta1.BuildOrSignStatus {
+	for _, imageState := range mbscObj.Status.Images {
+		if imageState.Image == image && imageState.Action == action {
+			return imageState.Status
+		}
+	}
+	return kmmv1beta1.BuildOrSignStatus("")
+}
+
 func setModuleImageSpec(mbscObj *kmmv1beta1.ModuleBuildSignConfig, moduleImageSpec *kmmv1beta1.ModuleImageSpec, action kmmv1beta1.BuildOrSignAction) {
 	specEntry := kmmv1beta1.ModuleBuildSignSpec{
 		ModuleImageSpec: *moduleImageSpec,

internal/mbsc/mbsc_test.go

@@ -226,3 +226,42 @@ var _ = Describe("SetImageSpec", func() {
 		Expect(testMBSC.Status.Images[2].Action).To(Equal(kmmv1beta1.BuildImage))
 	})
 })
+
+var _ = Describe("GetImageStatus", func() {
+	testMBSC := kmmv1beta1.ModuleBuildSignConfig{
+		Status: kmmv1beta1.ModuleBuildSignConfigStatus{
+			Images: []kmmv1beta1.BuildSignImageState{
+				{
+					Image:  "image1",
+					Status: kmmv1beta1.ActionSuccess,
+					Action: kmmv1beta1.BuildImage,
+				},
+				{
+					Image:  "image2",
+					Status: kmmv1beta1.ActionFailure,
+					Action: kmmv1beta1.SignImage,
+				},
+			},
+		},
+	}
+
+	mbscAPI := New(nil, nil)
+
+	It("get images status for both present and not present statuses", func() {
+		By("image and action are present")
+		res := mbscAPI.GetImageStatus(&testMBSC, "image1", kmmv1beta1.BuildImage)
+		Expect(res).To(Equal(kmmv1beta1.ActionSuccess))
+
+		By("image present, action missing")
+		res = mbscAPI.GetImageStatus(&testMBSC, "image2", kmmv1beta1.BuildImage)
+		Expect(res).To(Equal(kmmv1beta1.BuildOrSignStatus("")))
+
+		By("image missing, action present")
+		res = mbscAPI.GetImageStatus(&testMBSC, "image3", kmmv1beta1.BuildImage)
+		Expect(res).To(Equal(kmmv1beta1.BuildOrSignStatus("")))
+
+		By("image missing, action missing")
+		res = mbscAPI.GetImageStatus(&testMBSC, "image3", kmmv1beta1.SignImage)
+		Expect(res).To(Equal(kmmv1beta1.BuildOrSignStatus("")))
+	})
+})