Cleanup module.ImageExists. module.ImageDigest functions and their dependencies

Since we now check if images exists using the new MIC object.
Those functions are now redundant, this commit deletes them and their dependencies (registry and auth packages).

Author: TomerNewman

cmd/manager-hub/main.go

@@ -50,7 +50,6 @@ import (
 	"github.com/kubernetes-sigs/kernel-module-management/internal/metrics"
 	"github.com/kubernetes-sigs/kernel-module-management/internal/module"
 	"github.com/kubernetes-sigs/kernel-module-management/internal/nmc"
-	"github.com/kubernetes-sigs/kernel-module-management/internal/registry"
 	"github.com/kubernetes-sigs/kernel-module-management/internal/statusupdater"
 	//+kubebuilder:scaffold:imports
 )
@@ -111,7 +110,6 @@ func main() {
 	metricsAPI := metrics.New()
 	metricsAPI.Register()
 
-	registryAPI := registry.NewRegistry()
 	buildSignCombiner := module.NewCombiner()
 	resourceManager := buildsignresource.NewResourceManager(client, buildSignCombiner, scheme)
 
@@ -129,7 +127,7 @@ func main() {
 	ctx := ctrl.SetupSignalHandler()
 	mcmr := hub.NewManagedClusterModuleReconciler(
 		client,
-		manifestwork.NewCreator(client, scheme, kernelAPI, registryAPI, operatorNamespace),
+		manifestwork.NewCreator(client, scheme, kernelAPI, operatorNamespace),
 		cluster.NewClusterAPI(client, kernelAPI, operatorNamespace),
 		statusupdater.NewManagedClusterModuleStatusUpdater(client),
 		filterAPI,

cmd/manager/main.go

@@ -38,8 +38,6 @@ import (
 	"github.com/kubernetes-sigs/kernel-module-management/internal/metrics"
 	"github.com/kubernetes-sigs/kernel-module-management/internal/module"
 	"github.com/kubernetes-sigs/kernel-module-management/internal/nmc"
-	"github.com/kubernetes-sigs/kernel-module-management/internal/registry"
-
 	"k8s.io/apimachinery/pkg/runtime"
 	utilruntime "k8s.io/apimachinery/pkg/util/runtime"
 	clientgoscheme "k8s.io/client-go/kubernetes/scheme"
@@ -116,7 +114,6 @@ func main() {
 	metricsAPI := metrics.New()
 	metricsAPI.Register()
 
-	registryAPI := registry.NewRegistry()
 	buildSignCombinerAPI := module.NewCombiner()
 	resourceManager := buildsignresource.NewResourceManager(client, buildSignCombinerAPI, scheme)
 	nodeAPI := node.NewNode(client)
@@ -138,7 +135,6 @@ func main() {
 	mnc := controllers.NewModuleReconciler(
 		client,
 		kernelAPI,
-		registryAPI,
 		nmcHelper,
 		filterAPI,
 		nodeAPI,

internal/auth/auth.go

@@ -16,7 +16,6 @@ import (
 	"github.com/kubernetes-sigs/kernel-module-management/internal/module"
 	"github.com/kubernetes-sigs/kernel-module-management/internal/nmc"
 	"github.com/kubernetes-sigs/kernel-module-management/internal/node"
-	"github.com/kubernetes-sigs/kernel-module-management/internal/registry"
 	"github.com/kubernetes-sigs/kernel-module-management/internal/utils"
 	v1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -72,13 +71,12 @@ type ModuleReconciler struct {
 
 func NewModuleReconciler(client client.Client,
 	kernelAPI module.KernelMapper,
-	registryAPI registry.Registry,
 	nmcHelper nmc.Helper,
 	filter *filter.Filter,
 	nodeAPI node.Node,
 	micAPI mic.MIC,
 	scheme *runtime.Scheme) *ModuleReconciler {
-	reconHelper := newModuleReconcilerHelper(client, kernelAPI, registryAPI, micAPI, nmcHelper, scheme)
+	reconHelper := newModuleReconcilerHelper(client, kernelAPI, micAPI, nmcHelper, scheme)
 	return &ModuleReconciler{
 		filter:      filter,
 		nsLabeler:   newNamespaceLabeler(client),
@@ -195,28 +193,25 @@ type moduleReconcilerHelperAPI interface {
 }
 
 type moduleReconcilerHelper struct {
-	client      client.Client
-	kernelAPI   module.KernelMapper
-	registryAPI registry.Registry
-	micAPI      mic.MIC
-	nmcHelper   nmc.Helper
-	scheme      *runtime.Scheme
+	client    client.Client
+	kernelAPI module.KernelMapper
+	micAPI    mic.MIC
+	nmcHelper nmc.Helper
+	scheme    *runtime.Scheme
 }
 
 func newModuleReconcilerHelper(
 	client client.Client,
 	kernelAPI module.KernelMapper,
-	registryAPI registry.Registry,
 	micAPI mic.MIC,
 	nmcHelper nmc.Helper,
 	scheme *runtime.Scheme) moduleReconcilerHelperAPI {
 	return &moduleReconcilerHelper{
-		client:      client,
-		kernelAPI:   kernelAPI,
-		registryAPI: registryAPI,
-		micAPI:      micAPI,
-		nmcHelper:   nmcHelper,
-		scheme:      scheme,
+		client:    client,
+		kernelAPI: kernelAPI,
+		micAPI:    micAPI,
+		nmcHelper: nmcHelper,
+		scheme:    scheme,
 	}
 }