Fixing buildsignpodmanager Status constants

When defining constants for Status type, the type must also be defined,
otherwise those value are of type string

Author: yevgeny-shnaidman

internal/pod/buildsignpodmanager.go

@@ -18,10 +18,10 @@ const (
 	PodTypeBuild = "build"
 	PodTypeSign  = "sign"
 
-	StatusCompleted  = "completed"
-	StatusCreated    = "created"
-	StatusInProgress = "in progress"
-	StatusFailed     = "failed"
+	StatusCompleted  Status = "completed"
+	StatusCreated    Status = "created"
+	StatusInProgress Status = "in progress"
+	StatusFailed     Status = "failed"
 )
 
 var ErrNoMatchingPod = errors.New("no matching pod")

internal/pod/buildsignpodmanager_test.go

@@ -420,21 +420,21 @@ var _ = Describe("PodStatus", func() {
 	})
 
 	DescribeTable("should return the correct status depending on the pod status",
-		func(s *v1.Pod, podStatus string, expectsErr bool) {
+		func(s *v1.Pod, podStatus Status, expectsErr bool) {
 
 			res, err := bspm.GetPodStatus(s)
 			if expectsErr {
 				Expect(err).To(HaveOccurred())
 				return
 			}
 
-			Expect(string(res)).To(Equal(podStatus))
+			Expect(res).To(Equal(podStatus))
 		},
 		Entry("succeeded", &v1.Pod{Status: v1.PodStatus{Phase: v1.PodSucceeded}}, StatusCompleted, false),
 		Entry("in progress", &v1.Pod{Status: v1.PodStatus{Phase: v1.PodRunning}}, StatusInProgress, false),
 		Entry("pending", &v1.Pod{Status: v1.PodStatus{Phase: v1.PodPending}}, StatusInProgress, false),
 		Entry("Failed", &v1.Pod{Status: v1.PodStatus{Phase: v1.PodFailed}}, StatusFailed, false),
-		Entry("Unknown", &v1.Pod{Status: v1.PodStatus{Phase: v1.PodUnknown}}, "", true),
+		Entry("Unknown", &v1.Pod{Status: v1.PodStatus{Phase: v1.PodUnknown}}, Status(""), true),
 	)
 })