adding additional API to the mbsc package

adding a new interface API that will be used by controllers

Author: yevgeny-shnaidman

internal/mbsc/mbsc.go

@@ -1,19 +1,30 @@
 package mbsc
 
 import (
+	"context"
+	"fmt"
 	kmmv1beta1 "github.com/kubernetes-sigs/kernel-module-management/api/v1beta1"
+
+	k8serrors "k8s.io/apimachinery/pkg/api/errors"
+	"k8s.io/apimachinery/pkg/types"
+	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
 //go:generate mockgen -source=mbsc.go -package=mbsc -destination=mock_mbsc.go
 
 type MBSC interface {
 	SetModuleImageSpec(mbscObj *kmmv1beta1.ModuleBuildSignConfig, moduleImageSpec *kmmv1beta1.ModuleImageSpec)
+	GetMBSC(ctx context.Context, name, namespace string) (*kmmv1beta1.ModuleBuildSignConfig, error)
 }
 
-type mbsc struct{}
+type mbsc struct {
+	client client.Client
+}
 
-func NewMBSC() MBSC {
-	return &mbsc{}
+func NewMBSC(client client.Client) MBSC {
+	return &mbsc{
+		client: client,
+	}
 }
 
 func (m *mbsc) SetModuleImageSpec(mbscObj *kmmv1beta1.ModuleBuildSignConfig, moduleImageSpec *kmmv1beta1.ModuleImageSpec) {
@@ -25,3 +36,15 @@ func (m *mbsc) SetModuleImageSpec(mbscObj *kmmv1beta1.ModuleBuildSignConfig, mod
 	}
 	mbscObj.Spec.Images = append(mbscObj.Spec.Images, *moduleImageSpec)
 }
+
+func (m *mbsc) GetMBSC(ctx context.Context, name, namespace string) (*kmmv1beta1.ModuleBuildSignConfig, error) {
+	mbsc := kmmv1beta1.ModuleBuildSignConfig{}
+	err := m.client.Get(ctx, types.NamespacedName{Name: name, Namespace: namespace}, &mbsc)
+	if err != nil {
+		if k8serrors.IsNotFound(err) {
+			return nil, nil
+		}
+		return nil, fmt.Errorf("failed to get ModuleBuildSignConfig object %s/%s: %v", namespace, name, err)
+	}
+	return &mbsc, nil
+}

internal/mbsc/mbsc_test.go

@@ -1,9 +1,17 @@
 package mbsc
 
 import (
+	"context"
+	"fmt"
+
 	kmmv1beta1 "github.com/kubernetes-sigs/kernel-module-management/api/v1beta1"
+	"github.com/kubernetes-sigs/kernel-module-management/internal/client"
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
+	gomock "go.uber.org/mock/gomock"
+	k8serrors "k8s.io/apimachinery/pkg/api/errors"
+	"k8s.io/apimachinery/pkg/runtime/schema"
+	"k8s.io/apimachinery/pkg/types"
 )
 
 var _ = Describe("SetModuleImageSpec", func() {
@@ -12,7 +20,7 @@ var _ = Describe("SetModuleImageSpec", func() {
 	)
 
 	BeforeEach(func() {
-		mbsc = NewMBSC()
+		mbsc = NewMBSC(nil)
 	})
 
 	It("MBSC does not have any images in spec", func() {
@@ -58,3 +66,44 @@ var _ = Describe("SetModuleImageSpec", func() {
 		Expect(len(mbscObj.Spec.Images)).To(Equal(2))
 	})
 })
+
+var _ = Describe("GetMBSC", func() {
+	var (
+		ctrl       *gomock.Controller
+		mockClient *client.MockClient
+		mbsc       MBSC
+	)
+
+	BeforeEach(func() {
+		ctrl = gomock.NewController(GinkgoT())
+		mockClient = client.NewMockClient(ctrl)
+		mbsc = NewMBSC(mockClient)
+	})
+
+	ctx := context.Background()
+
+	It("mbsc object does not exists", func() {
+		mockClient.EXPECT().Get(ctx, types.NamespacedName{Name: "some name", Namespace: "some namespace"}, gomock.Any()).Return(
+			k8serrors.NewNotFound(schema.GroupResource{}, "owner name"))
+
+		res, err := mbsc.GetMBSC(ctx, "some name", "some namespace")
+		Expect(err).To(BeNil())
+		Expect(res).To(BeNil())
+	})
+
+	It("client get returns some error", func() {
+		mockClient.EXPECT().Get(ctx, types.NamespacedName{Name: "some name", Namespace: "some namespace"}, gomock.Any()).Return(fmt.Errorf("some error"))
+
+		res, err := mbsc.GetMBSC(ctx, "some name", "some namespace")
+		Expect(err).To(HaveOccurred())
+		Expect(res).To(BeNil())
+	})
+
+	It("mbsc object exists", func() {
+		mockClient.EXPECT().Get(ctx, types.NamespacedName{Name: "some name", Namespace: "some namespace"}, gomock.Any()).Return(nil)
+
+		res, err := mbsc.GetMBSC(ctx, "some name", "some namespace")
+		Expect(err).To(BeNil())
+		Expect(res).ToNot(BeNil())
+	})
+})