diff --git a/internal/mic/mic.go b/internal/mic/mic.go index 96d9d35a2..36f3b5038 100644 --- a/internal/mic/mic.go +++ b/internal/mic/mic.go @@ -54,7 +54,7 @@ func (mici *micImpl) CreateOrPatch(ctx context.Context, name, ns string, images ImageRepoSecret: imageRepoSecret, } - return controllerutil.SetOwnerReference(owner, mic, mici.scheme) + return controllerutil.SetControllerReference(owner, mic, mici.scheme) }) if err != nil { return fmt.Errorf("failed to create or patch %s/%s: %v", ns, name, err) diff --git a/internal/mic/mic_test.go b/internal/mic/mic_test.go index 3d01f2cd2..b056c45d3 100644 --- a/internal/mic/mic_test.go +++ b/internal/mic/mic_test.go @@ -2,6 +2,7 @@ package mic import ( "context" + "fmt" kmmv1beta1 "github.com/kubernetes-sigs/kernel-module-management/api/v1beta1" v1beta1 "github.com/kubernetes-sigs/kernel-module-management/api/v1beta1" @@ -42,13 +43,13 @@ var _ = Describe("ApplyMIC", func() { It("should fail if we failed to create or patch", func() { - mockClient.EXPECT().Get(ctx, gomock.Any(), gomock.Any()).Return(nil) + mockClient.EXPECT().Get(ctx, gomock.Any(), gomock.Any()).Return(fmt.Errorf("some error")) - err := micAPI.CreateOrPatch(ctx, micName, micNamespace, []v1beta1.ModuleImageSpec{}, nil, nil) + err := micAPI.CreateOrPatch(ctx, micName, micNamespace, []v1beta1.ModuleImageSpec{}, nil, &kmmv1beta1.Module{}) Expect(err).To(HaveOccurred()) Expect(err.Error()).To(ContainSubstring("failed to create or patch")) - Expect(err.Error()).To(ContainSubstring("cannot call SetOwnerReference")) + Expect(err.Error()).To(ContainSubstring("some error")) }) It("should create the MIC if it doesn't exist", func() {