Skip to content

Commit 641920a

Browse files
corneliusweigk8s-ci-robot
authored andcommitted
Minor fixes for the release (#341)
- use tar.gz for installation smoke test on windows - align manifest template with krew-index - explicitly enable go modules when building the binaries
1 parent 0837beb commit 641920a

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

docs/RELEASING_KREW.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
KREW_ROOT="$(mktemp -d)" KREW_OS=linux \
1919
$krew install --manifest=out/krew.yaml --archive=out/krew.tar.gz && \
2020
KREW_ROOT="$(mktemp -d)" KREW_OS=windows \
21-
$krew install --manifest=out/krew.yaml --archive=out/krew.zip
21+
$krew install --manifest=out/krew.yaml --archive=out/krew.tar.gz
2222
```
2323

2424
### Release a new version

hack/krew.yaml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ metadata:
1818
name: krew
1919
spec:
2020
version: "KREW_TAG"
21+
homepage: https://sigs.k8s.io/krew
2122
shortDescription: Package manager for kubectl plugins.
2223
caveats: |
2324
krew is now installed! To start using kubectl plugins, you need to add
@@ -30,8 +31,12 @@ spec:
3031
3132
* Windows: Add %USERPROFILE%\.krew\bin to your PATH environment variable
3233
33-
Run "kubectl krew" to list krew commands and get help.
34-
You can find documentation at https://github.com/kubernetes-sigs/krew.
34+
To list krew commands and to get help, run:
35+
$ kubectl krew
36+
For a full list of available plugins, run:
37+
$ kubectl krew search
38+
39+
You can find documentation at https://sigs.k8s.io/krew.
3540
3641
platforms:
3742
- uri: https://github.com/kubernetes-sigs/krew/releases/download/KREW_TAG/krew.tar.gz

hack/make-binaries.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ git_rev="${SHORT_SHA:-$(git rev-parse --short HEAD)}"
3737
git_tag="${TAG_NAME:-$(git describe --tags --dirty --always)}"
3838
echo >&2 "(Stamping with git tag=${git_tag} rev=${git_rev})"
3939

40-
env CGO_ENABLED=0 gox -osarch="${OSARCH:-$supported_platforms}" \
40+
env GO111MODULE=on CGO_ENABLED=0 gox -osarch="${OSARCH:-$supported_platforms}" \
4141
-tags netgo \
4242
-mod readonly \
4343
-ldflags="-w -X ${version_pkg}.gitCommit=${git_rev} \

0 commit comments

Comments
 (0)