Update to Go 1.22 and latest Go dependencies (#854)

* Update to Go 1.22

Signed-off-by: Marvin Beckers <[email protected]>

* Update k8s.io dependencies to v1.29 or latest versions

Signed-off-by: Marvin Beckers <[email protected]>

* Update spf13/cobra to v1.8.0

Signed-off-by: Marvin Beckers <[email protected]>

* Update to golangci-lint v1.57.2

Signed-off-by: Marvin Beckers <[email protected]>

* fix linter complaints surfaced by new linter versions

Signed-off-by: Marvin Beckers <[email protected]>

---------

Signed-off-by: Marvin Beckers <[email protected]>

Author: embik

.github/workflows/ci.yml

@@ -18,7 +18,7 @@ jobs:
     - name: Set up Go ${{ matrix.goVer }}
       uses: actions/setup-go@v3
       with:
-        go-version: '1.20'
+        go-version: '1.22'
       id: go
 
     - name: Check out code into the Go module directory

.golangci.yml

@@ -28,18 +28,19 @@ linters-settings:
 
 # options for analysis running
 run:
+  # include test files
+  tests: true
+
+issues:
   # which dirs to skip: they won't be analyzed;
   # can use regexp here: generated.*, regexp is applied on full path;
   # default value is empty list, but next dirs are always skipped independently
   # from this option's value:
   #   	vendor$, third_party$, testdata$, examples$, Godeps$, builtin$
-  skip-dirs:
+  exclude-dirs:
     - hack
     - docs
 
-  # include test files
-  tests: true
-
 linters:
   disable-all: true
   enable:

cmd/krew/cmd/info.go

@@ -38,7 +38,7 @@ var infoCmd = &cobra.Command{
 	Long:  `Show detailed information about an available plugin.`,
 	Example: `  kubectl krew info PLUGIN
   kubectl krew info INDEX/PLUGIN`,
-	RunE: func(cmd *cobra.Command, args []string) error {
+	RunE: func(_ *cobra.Command, args []string) error {
 		index, plugin := pathutil.CanonicalPluginName(args[0])
 
 		p, err := indexscanner.LoadPluginByName(paths.IndexPluginsPath(index), plugin)

cmd/krew/cmd/list.go

@@ -40,7 +40,7 @@ Remarks:
   the names of the plugins installed. This output can be piped back to the
   "install" command.`,
 		Aliases: []string{"ls"},
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(_ *cobra.Command, _ []string) error {
 			receipts, err := installation.GetInstalledPluginReceipts(paths.InstallReceiptsPath())
 			if err != nil {
 				return errors.Wrap(err, "failed to find all installed versions")

cmd/krew/cmd/search.go

@@ -66,7 +66,7 @@ Examples:
 
   To fuzzy search plugins with a keyword:
     kubectl krew search KEYWORD`,
-	RunE: func(cmd *cobra.Command, args []string) error {
+	RunE: func(_ *cobra.Command, args []string) error {
 		indexes, err := indexoperations.ListIndexes(paths)
 		if err != nil {
 			return errors.Wrap(err, "failed to list indexes")

cmd/krew/cmd/uninstall.go

@@ -37,7 +37,7 @@ Example:
 
 Remarks:
   Failure to uninstall a plugin will result in an error and exit immediately.`,
-	RunE: func(cmd *cobra.Command, args []string) error {
+	RunE: func(_ *cobra.Command, args []string) error {
 		for _, name := range args {
 			if isCanonicalName(name) {
 				return errors.New("uninstall command does not support INDEX/PLUGIN syntax; just specify PLUGIN")

cmd/krew/cmd/upgrade.go

@@ -43,7 +43,7 @@ This will reinstall all plugins that have a newer version in the local index.
 Use "kubectl krew update" to renew the index.
 To only upgrade single plugins provide them as arguments:
 kubectl krew upgrade foo bar"`,
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(_ *cobra.Command, args []string) error {
 			var ignoreUpgraded bool
 			var skipErrors bool
 

cmd/krew/cmd/version.go

@@ -39,7 +39,7 @@ Remarks:
   - IndexPath is the directory that stores the local copy of the index git repository.
   - InstallPath is the directory for plugin installations.
   - BinPath is the directory for the symbolic links to the installed plugin executables.`,
-	RunE: func(cmd *cobra.Command, args []string) error {
+	RunE: func(_ *cobra.Command, _ []string) error {
 		conf := [][]string{
 			{"GitTag", version.GitTag()},
 			{"GitCommit", version.GitCommit()},

cmd/validate-krew-manifest/main.go

@@ -182,7 +182,7 @@ var licenseFiles = map[string]struct{}{
 func validateLicenseFileExists(krewRoot string) error {
 	dir := environment.NewPaths(krewRoot).InstallPath()
 	var files []string
-	err := filepath.Walk(dir, func(path string, info os.FileInfo, err error) error {
+	err := filepath.Walk(dir, func(_ string, info os.FileInfo, err error) error {
 		if err != nil {
 			return err
 		}

go.mod

@@ -1,23 +1,23 @@
 module sigs.k8s.io/krew
 
-go 1.20
+go 1.22
 
 require (
 	github.com/fatih/color v1.15.0
-	github.com/google/go-cmp v0.5.9
+	github.com/google/go-cmp v0.6.0
 	github.com/mattn/go-isatty v0.0.19
 	github.com/pkg/errors v0.9.1
 	github.com/sahilm/fuzzy v0.1.0
-	github.com/spf13/cobra v1.7.0
+	github.com/spf13/cobra v1.8.0
 	github.com/spf13/pflag v1.0.5
-	k8s.io/apimachinery v0.27.3
-	k8s.io/client-go v11.0.0+incompatible
-	k8s.io/klog/v2 v2.100.1
-	sigs.k8s.io/yaml v1.3.0
+	k8s.io/apimachinery v0.29.3
+	k8s.io/client-go v0.29.3
+	k8s.io/klog/v2 v2.120.1
+	sigs.k8s.io/yaml v1.4.0
 )
 
 require (
-	github.com/go-logr/logr v1.2.4 // indirect
+	github.com/go-logr/logr v1.4.1 // indirect
 	github.com/gogo/protobuf v1.3.2 // indirect
 	github.com/google/gofuzz v1.2.0 // indirect
 	github.com/inconshreveable/mousetrap v1.1.0 // indirect
@@ -26,12 +26,12 @@ require (
 	github.com/mattn/go-colorable v0.1.13 // indirect
 	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
 	github.com/modern-go/reflect2 v1.0.2 // indirect
-	golang.org/x/net v0.12.0 // indirect
-	golang.org/x/sys v0.10.0 // indirect
-	golang.org/x/text v0.11.0 // indirect
+	golang.org/x/net v0.19.0 // indirect
+	golang.org/x/sys v0.15.0 // indirect
+	golang.org/x/text v0.14.0 // indirect
 	gopkg.in/inf.v0 v0.9.1 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
-	k8s.io/utils v0.0.0-20230711102312-30195339c3c7 // indirect
+	k8s.io/utils v0.0.0-20230726121419-3b25d923346b // indirect
 	sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd // indirect
-	sigs.k8s.io/structured-merge-diff/v4 v4.3.0 // indirect
+	sigs.k8s.io/structured-merge-diff/v4 v4.4.1 // indirect
 )