Fix: Non-constant format string in PrintWarning (#877)

mikelolasagasti · web-flow · commit 81a9313a70b1 · 2025-06-29T15:52:30.000-07:00
Signed-off-by: Mikel Olasagasti Uranga &lt;mikel@olasagasti.info&gt;
diff --git a/cmd/krew/cmd/root.go b/cmd/krew/cmd/root.go
@@ -114,7 +114,7 @@ func init() {
 func preRun(_ *cobra.Command, _ []string) error {
 	// check must be done before ensureDirs, to detect krew's self-installation
 	if !internal.IsBinDirInPATH(paths) {
-		internal.PrintWarning(os.Stderr, internal.SetupInstructions()+"\n\n")
+		internal.PrintWarning(os.Stderr, "%s", internal.SetupInstructions()+"\n\n")
 	}
 
 	if err := ensureDirs(paths.BasePath(),

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ func init() {`
`114`	`114`	`func preRun(_ *cobra.Command, _ []string) error {`
`115`	`115`	`// check must be done before ensureDirs, to detect krew's self-installation`
`116`	`116`	`if !internal.IsBinDirInPATH(paths) {`
`117`		`- internal.PrintWarning(os.Stderr, internal.SetupInstructions()+"\n\n")`
	`117`	`+ internal.PrintWarning(os.Stderr, "%s", internal.SetupInstructions()+"\n\n")`
`118`	`118`	`}`
`119`	`119`
`120`	`120`	`if err := ensureDirs(paths.BasePath(),`