Improve error messages when installing from manifest+archive (#361)

* Improve error messages when installing from manifest+archive

* Improve error message when opening a local archive fails

Author: corneliusweig

pkg/download/downloader.go

@@ -209,7 +209,7 @@ func NewDownloader(v Verifier, f Fetcher) Downloader {
 func (d Downloader) Get(uri, dst string) error {
 	body, size, err := download(uri, d.verifier, d.fetcher)
 	if err != nil {
-		return errors.Wrapf(err, "failed to get the uri %q", uri)
+		return err
 	}
 	return extractArchive(dst, body, size)
 }

pkg/download/fetch.go

@@ -37,7 +37,7 @@ type HTTPFetcher struct{}
 func (HTTPFetcher) Get(uri string) (io.ReadCloser, error) {
 	resp, err := http.Get(uri)
 	if err != nil {
-		return nil, err
+		return nil, errors.Wrapf(err, "failed to get the uri %q", uri)
 	}
 	return resp.Body, nil
 }
@@ -47,7 +47,8 @@ var _ Fetcher = fileFetcher{}
 type fileFetcher struct{ f string }
 
 func (f fileFetcher) Get(_ string) (io.ReadCloser, error) {
-	return os.Open(f.f)
+	file, err := os.Open(f.f)
+	return file, errors.Wrapf(err, "failed to open archive file %q for reading", f.f)
 }
 
 // NewFileFetcher returns a local file reader.

pkg/installation/install.go

@@ -95,7 +95,7 @@ func install(op installOperation, opts InstallOpts) error {
 	// Download and extract
 	glog.V(3).Infof("Creating download staging directory %q", op.downloadStagingDir)
 	if err := os.MkdirAll(op.downloadStagingDir, 0755); err != nil {
-		return errors.Wrapf(err, "could not create download path %q", op.downloadStagingDir)
+		return errors.Wrapf(err, "could not create staging dir %q", op.downloadStagingDir)
 	}
 	defer func() {
 		glog.V(3).Infof("Deleting the download staging directory %s", op.downloadStagingDir)
@@ -104,7 +104,7 @@ func install(op installOperation, opts InstallOpts) error {
 		}
 	}()
 	if err := downloadAndExtract(op.downloadStagingDir, op.platform.URI, op.platform.Sha256, opts.ArchiveFileOverride); err != nil {
-		return errors.Wrap(err, "failed to download and extract")
+		return errors.Wrap(err, "failed to unpack into staging dir")
 	}
 
 	applyDefaults(&op.platform)
@@ -146,7 +146,7 @@ func downloadAndExtract(extractDir, uri, sha256sum, overrideFile string) error {
 
 	verifier := download.NewSha256Verifier(sha256sum)
 	err := download.NewDownloader(verifier, fetcher).Get(uri, extractDir)
-	return errors.Wrap(err, "failed to download and verify file")
+	return errors.Wrap(err, "failed to unpack the plugin archive")
 }
 
 // Uninstall will uninstall a plugin.